Skip to content

[next] wasmtime: fix build due to cargo-auditable issue#253265

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
ereslibre:fix-wasmtime-staging-next
Sep 6, 2023
Merged

[next] wasmtime: fix build due to cargo-auditable issue#253265
vcunat merged 1 commit intoNixOS:staging-nextfrom
ereslibre:fix-wasmtime-staging-next

Conversation

@ereslibre
Copy link
Copy Markdown
Member

cargo-auditable is not able to process the c-api crate Cargo.toml due to the inclusion of the new dep: keyword in crate features.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

`cargo-auditable` is not able to process the `c-api` crate
`Cargo.toml` due to the inclusion of the new `dep:` keyword in crate
features.
@ereslibre ereslibre force-pushed the fix-wasmtime-staging-next branch from bbb6682 to 884c080 Compare September 4, 2023 13:50
@ereslibre ereslibre changed the title wasmtime: fix build due to cargo-auditable issue [next] wasmtime: fix build due to cargo-auditable issue Sep 4, 2023
@ofborg ofborg bot requested a review from matthewbauer September 4, 2023 13:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 4, 2023
@vcunat vcunat merged commit 401c8ea into NixOS:staging-next Sep 6, 2023
@ereslibre ereslibre deleted the fix-wasmtime-staging-next branch September 6, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants