Skip to content

edge-runtime: 1.10.0 -> 1.14.0#253180

Merged
happysalada merged 1 commit intoNixOS:staging-nextfrom
happysalada:update_edge_runtime
Sep 4, 2023
Merged

edge-runtime: 1.10.0 -> 1.14.0#253180
happysalada merged 1 commit intoNixOS:staging-nextfrom
happysalada:update_edge_runtime

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Sep 3, 2023 •
edited
Loading

Description of changes

update of the package to fix build with rust 1.72

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Sep 3, 2023

Result of nixpkgs-review pr 253180 run on x86_64-linux 1

1 package failed to build:
  • edge-runtime

@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Sep 3, 2023

Result of nixpkgs-review pr 253180 run on x86_64-linux 1

1 package built:
  • edge-runtime

@happysalada happysalada mentioned this pull request Sep 3, 2023
Merged
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 3, 2023
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Sep 4, 2023

FYI, ofBorg says that darwin needs more fixes. Hydra says it did build on current nixpkgs master. But sure, it's better when at least part is fixed than nothing.

@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Sep 4, 2023

the error was a missing SystemConfiguration, I've just added it.

@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Sep 4, 2023

alright, the darwin build just timed out, I'm going to merge then.
Thanks for reviewing!

@happysalada happysalada merged commit bcbbfd8 into NixOS:staging-next Sep 4, 2023
@happysalada happysalada deleted the update_edge_runtime branch September 4, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@happysalada @vcunat