Skip to content

shared-mime-info: 2.2 -> 2.2-37-g9b8ad99#252576

Closed
ghost wants to merge 1 commit intostagingfrom
unknown repository
Closed

shared-mime-info: 2.2 -> 2.2-37-g9b8ad99#252576
ghost wants to merge 1 commit intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 31, 2023

Description of changes

Pull in new MIME info.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jtojnar and mimame August 31, 2023 14:21
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 31, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 31, 2023

I can't switch branches without mass-pinging. I'm not doing it wrong, the bot is the problem, not me.

@figsoda
Copy link
Copy Markdown
Member

figsoda commented Aug 31, 2023

You should be able to mark the PR as draft before doing the rebase. CONTRIBUTING.md has a guide on rebasing.

I'm unsubscribing to this thread, feel free to ping me again if you want to respond to me or anything else :)

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 31, 2023

I tried that with a draft and I­ thought it mass pinged #252574

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Aug 31, 2023
@ofborg ofborg bot requested a review from jtojnar August 31, 2023 15:03
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels Aug 31, 2023
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 1, 2023

The rebuilds are from glib using this info in its tests.

@tobim tobim mentioned this pull request Oct 8, 2023
Merged
12 tasks
@toonn
Copy link
Copy Markdown
Contributor

toonn commented Oct 11, 2023

Closing because we merged #259727.

@toonn toonn closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimame mimame Awaiting requested review from mimame

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@figsoda @toonn