python3Packages.tpm2-pytss: disable hardening#252525
Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom Sep 1, 2023
Merged
python3Packages.tpm2-pytss: disable hardening#252525RaitoBezarius merged 1 commit intoNixOS:masterfrom
RaitoBezarius merged 1 commit intoNixOS:masterfrom
Conversation
Member
|
Result of 7 packages built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2617 |
Hardening got enabled in NixOS#246244 in a way that makes it difficult to disable for projects to disable selectively. The fix used in NixOS#245139 (and provided upstream) no longer works, and we need to disable hardening entirely to make `pycparser` which is unable to handle fortify bits. Fixes NixOS#252023. Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
cf5b2db to
29afe51
Compare
RaitoBezarius
approved these changes
Sep 1, 2023
Member
RaitoBezarius
left a comment
There was a problem hiding this comment.
I modified the commit myself to expedite it as I know you are probably not available to do the changes, LGTM for me otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Hardening got enabled in #246244 in a way that makes it difficult to disable selectively for project. The fix used in #245139 (and provided upstream) no longer works, and we need to disable hardening entirely to make
pycparserwork (it's unable to handle fortify bits of glibc headers).Fixes #252023.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)