nixos/kanidm: fix broken doc links#252524
Merged
erictapen merged 1 commit intoNixOS:masterfrom Aug 31, 2023
Merged
Conversation
Contributor
Author
|
Wasn't sure what to tick since I only made changes to option descriptions. |
Member
|
Thanks, can you follow the guidelines for the commit message at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ? |
Contributor
Author
|
@nagy Fixed (?) |
Member
|
Since it is a nixos module it needs the prefix. I would suggest |
Contributor
Author
nagy
approved these changes
Aug 31, 2023
Flakebi
approved these changes
Aug 31, 2023
Member
Flakebi
left a comment
There was a problem hiding this comment.
Thank you!
Looks obviously good to me
1 task
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix broken Kanidm docs links, also use documentation portal instead of links to MD pages in GH
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)