guile: fix build with clang 16 on x86_64-darwin#252438
Merged
vcunat merged 2 commits intoNixOS:stagingfrom Sep 28, 2023
Merged
Conversation
Guile 2.2 calls `__sincos`, which should be defined in `math.h`, but the version of that header in the 10.12 SDK is very old (predating 10.12). Until there is a version of that header available, use the 11.0 SDK to build Guile.
Guile 3.0 calls `__sincos`, which should be defined in `math.h`, but the version of that header in the 10.12 SDK is very old (predating 10.12). Until there is a version of that header available, use the 11.0 SDK to build Guile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Guile 2.2 and 3.0 use
__sincos, which should be part of the 10.12 SDK but is not due to the header being out of date. This results in a build failure with clang 16. Using the 11.0 SDK works around the issue.While there shouldn’t be any rebuilds except on x86_64-darwin, targeting staging because it has ~700.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)