Skip to content

bcachefs: 2023-06-28 -> 2023-09-12#252348

Closed
Madouura wants to merge 3 commits intoNixOS:masterfrom
Madouura:pr/bcachefs
Closed

bcachefs: 2023-06-28 -> 2023-09-12#252348
Madouura wants to merge 3 commits intoNixOS:masterfrom
Madouura:pr/bcachefs

Conversation

@Madouura
Copy link
Copy Markdown
Contributor

Description of changes

Updating bcachefs.
All tests except for bcachefsEncrypted succeed.
Given that encryption still works on my machine, without segfaulting, the test itself or the VM environment seems to be the problem.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Aug 30, 2023
@ofborg ofborg bot requested a review from davidak August 30, 2023 14:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 30, 2023
@gepbird
Copy link
Copy Markdown
Contributor

gepbird commented Aug 31, 2023

Result of nixpkgs-review pr 252348 run on x86_64-linux 1

42 packages marked as broken and skipped:
  • linuxKernel.packages.linux_testing_bcachefs.akvcam
  • linuxKernel.packages.linux_testing_bcachefs.can-isotp
  • linuxKernel.packages.linux_testing_bcachefs.dddvb
  • linuxKernel.packages.linux_testing_bcachefs.intel-speed-select
  • linuxKernel.packages.linux_testing_bcachefs.ixgbevf
  • linuxKernel.packages.linux_testing_bcachefs.lkrg
  • linuxKernel.packages.linux_testing_bcachefs.mxu11x0
  • linuxKernel.packages.linux_testing_bcachefs.ndiswrapper
  • linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy340
  • linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy340.bin
  • linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy390
  • linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy390.bin
  • linuxKernel.packages.linux_testing_bcachefs.nvidiabl
  • linuxKernel.packages.linux_testing_bcachefs.phc-intel
  • linuxKernel.packages.linux_testing_bcachefs.r8125
  • linuxKernel.packages.linux_testing_bcachefs.r8168
  • linuxKernel.packages.linux_testing_bcachefs.rtl8188eus-aircrack
  • linuxKernel.packages.linux_testing_bcachefs.tbs
  • linuxKernel.packages.linux_testing_bcachefs.zfs
  • linuxKernel.packages.linux_testing_bcachefs.zfsStable
  • linuxKernel.packages.linux_testing_bcachefs.zfsUnstable
  • linuxPackages_testing_bcachefs.akvcam
  • linuxPackages_testing_bcachefs.can-isotp
  • linuxPackages_testing_bcachefs.dddvb
  • linuxPackages_testing_bcachefs.intel-speed-select
  • linuxPackages_testing_bcachefs.ixgbevf
  • linuxPackages_testing_bcachefs.lkrg
  • linuxPackages_testing_bcachefs.mxu11x0
  • linuxPackages_testing_bcachefs.ndiswrapper
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy340
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy340.bin
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy390
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy390.bin
  • linuxPackages_testing_bcachefs.nvidiabl
  • linuxPackages_testing_bcachefs.phc-intel
  • linuxPackages_testing_bcachefs.r8125
  • linuxPackages_testing_bcachefs.r8168
  • linuxPackages_testing_bcachefs.rtl8188eus-aircrack
  • linuxPackages_testing_bcachefs.tbs
  • linuxPackages_testing_bcachefs.zfs
  • linuxPackages_testing_bcachefs.zfsStable
  • linuxPackages_testing_bcachefs.zfsUnstable
19 packages failed to build:
  • linuxPackages_testing_bcachefs.apfs (linuxKernel.packages.linux_testing_bcachefs.apfs)
  • linuxPackages_testing_bcachefs.cryptodev (linuxKernel.packages.linux_testing_bcachefs.cryptodev)
  • linuxPackages_testing_bcachefs.ddcci-driver (linuxKernel.packages.linux_testing_bcachefs.ddcci-driver)
  • linuxPackages_testing_bcachefs.dpdk (linuxKernel.packages.linux_testing_bcachefs.dpdk)
  • linuxPackages_testing_bcachefs.dpdk.doc (linuxKernel.packages.linux_testing_bcachefs.dpdk.doc)
  • linuxPackages_testing_bcachefs.dpdk.kmod (linuxKernel.packages.linux_testing_bcachefs.dpdk.kmod)
  • linuxPackages_testing_bcachefs.hyperv-daemons (linuxKernel.packages.linux_testing_bcachefs.hyperv-daemons)
  • linuxPackages_testing_bcachefs.ipu6-drivers (linuxKernel.packages.linux_testing_bcachefs.ipu6-drivers)
  • linuxPackages_testing_bcachefs.isgx (linuxKernel.packages.linux_testing_bcachefs.isgx)
  • linuxPackages_testing_bcachefs.kvdo (linuxKernel.packages.linux_testing_bcachefs.kvdo)
  • linuxPackages_testing_bcachefs.mba6x_bl (linuxKernel.packages.linux_testing_bcachefs.mba6x_bl)
  • linuxPackages_testing_bcachefs.mbp2018-bridge-drv (linuxKernel.packages.linux_testing_bcachefs.mbp2018-bridge-drv)
  • linuxPackages_testing_bcachefs.openafs (linuxKernel.packages.linux_testing_bcachefs.openafs ,linuxPackages_testing_bcachefs.openafs_1_8)
  • linuxPackages_testing_bcachefs.prl-tools (linuxKernel.packages.linux_testing_bcachefs.prl-tools)
  • linuxPackages_testing_bcachefs.rtl8821cu (linuxKernel.packages.linux_testing_bcachefs.rtl8821cu)
  • linuxPackages_testing_bcachefs.system76-acpi (linuxKernel.packages.linux_testing_bcachefs.system76-acpi)
  • linuxPackages_testing_bcachefs.virtio_vmmci (linuxKernel.packages.linux_testing_bcachefs.virtio_vmmci)
  • linuxPackages_testing_bcachefs.virtualboxGuestAdditions (linuxKernel.packages.linux_testing_bcachefs.virtualboxGuestAdditions)
  • linuxPackages_testing_bcachefs.vmware (linuxKernel.packages.linux_testing_bcachefs.vmware)
90 packages built:
  • bcachefs-tools
  • linux_testing_bcachefs (linuxPackages_testing_bcachefs.kernel)
  • linux_testing_bcachefs.dev (linuxPackages_testing_bcachefs.kernel.dev)
  • linuxPackages_testing_bcachefs.acpi_call (linuxKernel.packages.linux_testing_bcachefs.acpi_call)
  • linuxPackages_testing_bcachefs.asus-ec-sensors (linuxKernel.packages.linux_testing_bcachefs.asus-ec-sensors)
  • linuxPackages_testing_bcachefs.asus-wmi-sensors (linuxKernel.packages.linux_testing_bcachefs.asus-wmi-sensors)
  • linuxPackages_testing_bcachefs.ax99100 (linuxKernel.packages.linux_testing_bcachefs.ax99100)
  • linuxPackages_testing_bcachefs.batman_adv (linuxKernel.packages.linux_testing_bcachefs.batman_adv)
  • linuxPackages_testing_bcachefs.bbswitch (linuxKernel.packages.linux_testing_bcachefs.bbswitch)
  • linuxPackages_testing_bcachefs.broadcom_sta (linuxKernel.packages.linux_testing_bcachefs.broadcom_sta)
  • linuxPackages_testing_bcachefs.ch9344 (linuxKernel.packages.linux_testing_bcachefs.ch9344)
  • linuxPackages_testing_bcachefs.chipsec (linuxKernel.packages.linux_testing_bcachefs.chipsec)
  • linuxPackages_testing_bcachefs.chipsec.dist (linuxKernel.packages.linux_testing_bcachefs.chipsec.dist)
  • linuxPackages_testing_bcachefs.cpupower (linuxKernel.packages.linux_testing_bcachefs.cpupower)
  • linuxPackages_testing_bcachefs.digimend (linuxKernel.packages.linux_testing_bcachefs.digimend)
  • linuxPackages_testing_bcachefs.dpdk-kmods (linuxKernel.packages.linux_testing_bcachefs.dpdk-kmods)
  • linuxPackages_testing_bcachefs.ena (linuxKernel.packages.linux_testing_bcachefs.ena)
  • linuxPackages_testing_bcachefs.evdi (linuxKernel.packages.linux_testing_bcachefs.evdi)
  • linuxPackages_testing_bcachefs.facetimehd (linuxKernel.packages.linux_testing_bcachefs.facetimehd)
  • linuxPackages_testing_bcachefs.fanout (linuxKernel.packages.linux_testing_bcachefs.fanout)
  • linuxPackages_testing_bcachefs.fwts-efi-runtime (linuxKernel.packages.linux_testing_bcachefs.fwts-efi-runtime)
  • linuxPackages_testing_bcachefs.gcadapter-oc-kmod (linuxKernel.packages.linux_testing_bcachefs.gcadapter-oc-kmod)
  • linuxPackages_testing_bcachefs.hid-ite8291r3 (linuxKernel.packages.linux_testing_bcachefs.hid-ite8291r3)
  • linuxPackages_testing_bcachefs.hyperv-daemons.bin (linuxKernel.packages.linux_testing_bcachefs.hyperv-daemons.bin)
  • linuxPackages_testing_bcachefs.hyperv-daemons.lib (linuxKernel.packages.linux_testing_bcachefs.hyperv-daemons.lib)
  • linuxPackages_testing_bcachefs.it87 (linuxKernel.packages.linux_testing_bcachefs.it87)
  • linuxPackages_testing_bcachefs.ithc (linuxKernel.packages.linux_testing_bcachefs.ithc)
  • linuxPackages_testing_bcachefs.ivsc-driver (linuxKernel.packages.linux_testing_bcachefs.ivsc-driver)
  • linuxPackages_testing_bcachefs.jool (linuxKernel.packages.linux_testing_bcachefs.jool)
  • linuxPackages_testing_bcachefs.kvmfr (linuxKernel.packages.linux_testing_bcachefs.kvmfr)
  • linuxPackages_testing_bcachefs.lenovo-legion-module (linuxKernel.packages.linux_testing_bcachefs.lenovo-legion-module)
  • linuxPackages_testing_bcachefs.linux-gpib (linuxKernel.packages.linux_testing_bcachefs.linux-gpib)
  • linuxPackages_testing_bcachefs.liquidtux (linuxKernel.packages.linux_testing_bcachefs.liquidtux)
  • linuxPackages_testing_bcachefs.lttng-modules (linuxKernel.packages.linux_testing_bcachefs.lttng-modules)
  • linuxPackages_testing_bcachefs.mwprocapture (linuxKernel.packages.linux_testing_bcachefs.mwprocapture)
  • linuxPackages_testing_bcachefs.netatop (linuxKernel.packages.linux_testing_bcachefs.netatop)
  • linuxPackages_testing_bcachefs.new-lg4ff (linuxKernel.packages.linux_testing_bcachefs.new-lg4ff)
  • linuxPackages_testing_bcachefs.nvidia_x11 (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11 ,linuxPackages_testing_bcachefs.nvidia_x11_beta ,linuxPackages_testing_bcachefs.nvidia_x11_production)
  • linuxPackages_testing_bcachefs.nvidia_x11.bin (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11.bin ,linuxPackages_testing_bcachefs.nvidia_x11_beta.bin ,linuxPackages_testing_bcachefs.nvidia_x11_production.bin)
  • linuxPackages_testing_bcachefs.nvidia_x11.firmware (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11.firmware ,linuxPackages_testing_bcachefs.nvidia_x11_beta.firmware ,linuxPackages_testing_bcachefs.nvidia_x11_production.firmware)
  • linuxPackages_testing_bcachefs.nvidia_x11.lib32 (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11.lib32 ,linuxPackages_testing_bcachefs.nvidia_x11_beta.lib32 ,linuxPackages_testing_bcachefs.nvidia_x11_production.lib32)
  • linuxPackages_testing_bcachefs.nvidia_x11_beta_open (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_beta_open ,linuxPackages_testing_bcachefs.nvidia_x11_production_open ,linuxPackages_testing_bcachefs.nvidia_x11_stable_open)
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy470 (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy470)
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy470.bin (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy470.bin)
  • linuxPackages_testing_bcachefs.nvidia_x11_legacy470.lib32 (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_legacy470.lib32)
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_vulkan_beta)
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta.bin (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_vulkan_beta.bin)
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta.firmware (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_vulkan_beta.firmware)
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta.lib32 (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_vulkan_beta.lib32)
  • linuxPackages_testing_bcachefs.nvidia_x11_vulkan_beta_open (linuxKernel.packages.linux_testing_bcachefs.nvidia_x11_vulkan_beta_open)
  • linuxPackages_testing_bcachefs.openrazer (linuxKernel.packages.linux_testing_bcachefs.openrazer)
  • linuxPackages_testing_bcachefs.opensnitch-ebpf (linuxKernel.packages.linux_testing_bcachefs.opensnitch-ebpf)
  • linuxPackages_testing_bcachefs.perf (linuxKernel.packages.linux_testing_bcachefs.perf)
  • linuxPackages_testing_bcachefs.perf.debug (linuxKernel.packages.linux_testing_bcachefs.perf.debug)
  • linuxPackages_testing_bcachefs.ply (linuxKernel.packages.linux_testing_bcachefs.ply)
  • linuxPackages_testing_bcachefs.qc71_laptop (linuxKernel.packages.linux_testing_bcachefs.qc71_laptop)
  • linuxPackages_testing_bcachefs.rr-zen_workaround (linuxKernel.packages.linux_testing_bcachefs.rr-zen_workaround)
  • linuxPackages_testing_bcachefs.rtl8189es (linuxKernel.packages.linux_testing_bcachefs.rtl8189es)
  • linuxPackages_testing_bcachefs.rtl8189fs (linuxKernel.packages.linux_testing_bcachefs.rtl8189fs)
  • linuxPackages_testing_bcachefs.rtl8192eu (linuxKernel.packages.linux_testing_bcachefs.rtl8192eu)
  • linuxPackages_testing_bcachefs.rtl8723ds (linuxKernel.packages.linux_testing_bcachefs.rtl8723ds)
  • linuxPackages_testing_bcachefs.rtl8812au (linuxKernel.packages.linux_testing_bcachefs.rtl8812au)
  • linuxPackages_testing_bcachefs.rtl8814au (linuxKernel.packages.linux_testing_bcachefs.rtl8814au)
  • linuxPackages_testing_bcachefs.rtl8821au (linuxKernel.packages.linux_testing_bcachefs.rtl8821au)
  • linuxPackages_testing_bcachefs.rtl8821ce (linuxKernel.packages.linux_testing_bcachefs.rtl8821ce)
  • linuxPackages_testing_bcachefs.rtl88x2bu (linuxKernel.packages.linux_testing_bcachefs.rtl88x2bu)
  • linuxPackages_testing_bcachefs.rtl88xxau-aircrack (linuxKernel.packages.linux_testing_bcachefs.rtl88xxau-aircrack)
  • linuxPackages_testing_bcachefs.rtw88 (linuxKernel.packages.linux_testing_bcachefs.rtw88)
  • linuxPackages_testing_bcachefs.sysdig (linuxKernel.packages.linux_testing_bcachefs.sysdig)
  • linuxPackages_testing_bcachefs.system76 (linuxKernel.packages.linux_testing_bcachefs.system76)
  • linuxPackages_testing_bcachefs.system76-io (linuxKernel.packages.linux_testing_bcachefs.system76-io)
  • linuxPackages_testing_bcachefs.systemtap (linuxKernel.packages.linux_testing_bcachefs.systemtap)
  • linuxPackages_testing_bcachefs.tmon (linuxKernel.packages.linux_testing_bcachefs.tmon)
  • linuxPackages_testing_bcachefs.tp_smapi (linuxKernel.packages.linux_testing_bcachefs.tp_smapi)
  • linuxPackages_testing_bcachefs.trelay (linuxKernel.packages.linux_testing_bcachefs.trelay)
  • linuxPackages_testing_bcachefs.turbostat (linuxKernel.packages.linux_testing_bcachefs.turbostat)
  • linuxPackages_testing_bcachefs.tuxedo-keyboard (linuxKernel.packages.linux_testing_bcachefs.tuxedo-keyboard)
  • linuxPackages_testing_bcachefs.usbip (linuxKernel.packages.linux_testing_bcachefs.usbip)
  • linuxPackages_testing_bcachefs.v4l2loopback (linuxKernel.packages.linux_testing_bcachefs.v4l2loopback)
  • linuxPackages_testing_bcachefs.v4l2loopback.bin (linuxKernel.packages.linux_testing_bcachefs.v4l2loopback.bin)
  • linuxPackages_testing_bcachefs.v86d (linuxKernel.packages.linux_testing_bcachefs.v86d)
  • linuxPackages_testing_bcachefs.veikk-linux-driver (linuxKernel.packages.linux_testing_bcachefs.veikk-linux-driver)
  • linuxPackages_testing_bcachefs.vendor-reset (linuxKernel.packages.linux_testing_bcachefs.vendor-reset)
  • linuxPackages_testing_bcachefs.vhba (linuxKernel.packages.linux_testing_bcachefs.vhba)
  • linuxPackages_testing_bcachefs.virtualbox (linuxKernel.packages.linux_testing_bcachefs.virtualbox)
  • linuxPackages_testing_bcachefs.vmm_clock (linuxKernel.packages.linux_testing_bcachefs.vmm_clock)
  • linuxPackages_testing_bcachefs.x86_energy_perf_policy (linuxKernel.packages.linux_testing_bcachefs.x86_energy_perf_policy)
  • linuxPackages_testing_bcachefs.xone (linuxKernel.packages.linux_testing_bcachefs.xone)
  • linuxPackages_testing_bcachefs.xpadneo (linuxKernel.packages.linux_testing_bcachefs.xpadneo)
  • linuxPackages_testing_bcachefs.zenpower (linuxKernel.packages.linux_testing_bcachefs.zenpower)
Error logs:
error: builder for '/nix/store/7sp63wajc3nws8a2q1yrnfmfpqvbc6kb-apfs-0.3.3-6.5.drv' failed with exit code 2;
       last 10 log lines:
       >       |                                     FMODE_EXEC
       > /build/source/super.c:1575:21: error: 'struct super_block' has no member named 's_mode'; did you mean 's_mtd'?
       >  1575 |                 sb->s_mode = mode;
       >       |                     ^~~~~~
       >       |                     s_mtd
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/super.o] Error 1
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:17: default] Error 2
       For full logs, run 'nix log /nix/store/7sp63wajc3nws8a2q1yrnfmfpqvbc6kb-apfs-0.3.3-6.5.drv'.
error: builder for '/nix/store/sym32fiq13c5xbl3m7hsk02s38axaw46-cryptodev-linux-1.13-6.5.drv' failed with exit code 2;
       last 10 log lines:
       >       |                                   unregister_sysctl_table
       > /build/source/ioctl.c:1270:33: warning: assignment to 'struct ctl_table_header *' from 'int' makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;]                                                                                                                                       
       >  1270 |         verbosity_sysctl_header = register_sysctl_table(verbosity_ctl_root);
       >       |                                 ^
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/ioctl.o] Error 1
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:30: build] Error 2
       For full logs, run 'nix log /nix/store/sym32fiq13c5xbl3m7hsk02s38axaw46-cryptodev-linux-1.13-6.5.drv'.
error: builder for '/nix/store/m243qnzq03l5i92nzw6y86qq6fqbdja6-ddcci-driver-6.5-0.4.3.drv' failed with exit code 2;
       last 10 log lines:
       >    43 | static DEFINE_SEMAPHORE(core_lock);
       >       |        ^~~~~~~~~~~~~~~~
       > cc1: some warnings being treated as errors
       > make[4]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/ddcci/ddcci.o] Error 1
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source/ddcci] Error 2
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make[1]: *** [Makefile:38: ddcci.ko] Error 2
       > make[1]: Leaving directory '/build/source/ddcci'
       > make: *** [Makefile:28: ddcci] Error 2
       For full logs, run 'nix log /nix/store/m243qnzq03l5i92nzw6y86qq6fqbdja6-ddcci-driver-6.5-0.4.3.drv'.
error: builder for '/nix/store/ffdrlj2k4n1analr7601r5p1804hrmwj-VirtualBox-GuestAdditions-7.0.10-6.5.drv' failed with exit code 2;
       last 10 log lines:
       >   197 |         .fb_imageblit = drm_fb_helper_sys_imageblit,
       >       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
       > make[4]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/install/src/vboxguest-7.0.10/vboxvideo/vbox_fb.o] Error 1
       > make[4]: *** Waiting for unfinished jobs....
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/install/src/vboxguest-7.0.10/vboxvideo] Error 2
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make[1]: *** [/build/install/src/vboxguest-7.0.10/vboxvideo/Makefile-footer.gmk:133: vboxvideo] Error 2
       > make[1]: Leaving directory '/build/install/src/vboxguest-7.0.10/vboxvideo'
       > make: *** [Makefile:73: vboxvideo] Error 1
       For full logs, run 'nix log /nix/store/ffdrlj2k4n1analr7601r5p1804hrmwj-VirtualBox-GuestAdditions-7.0.10-6.5.drv'.
error: builder for '/nix/store/swjy87wzgza9xs8w8c9n30wk4bp8vvgb-isgx-2.14-6.5.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/sgx_main.c: In function 'sgx_mmap':
       > /build/source/sgx_main.c:112:23: error: assignment of read-only member 'vm_flags'
       >   112 |         vma->vm_flags |= VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP | VM_IO |
       >       |                       ^~
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/sgx_main.o] Error 1
       > make[3]: *** Waiting for unfinished jobs....
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:16: default] Error 2
       For full logs, run 'nix log /nix/store/swjy87wzgza9xs8w8c9n30wk4bp8vvgb-isgx-2.14-6.5.drv'.
error: builder for '/nix/store/c2wswnkzkvrhyi6ybhdqwy65fpcf4ylx-ipu6-drivers-unstable-2023-06-02.drv' failed with exit code 2;
       last 10 log lines:
       >       |      ^~~~~~~~~~~~~~
       >   CC [M]  /build/source/drivers/media/pci/intel/ipu6/ipu6-psys-gpc.o
       > make[5]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/drivers/media/pci/intel/ipu6/../ipu-psys.o] Error 1
       > make[5]: *** Waiting for unfinished jobs....
       > make[4]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:480: /build/source/drivers/media/pci/intel/ipu6] Error 2
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:480: /build/source/drivers/media/pci/intel] Error 2
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:72: all] Error 2
       For full logs, run 'nix log /nix/store/c2wswnkzkvrhyi6ybhdqwy65fpcf4ylx-ipu6-drivers-unstable-2023-06-02.drv'.
error: builder for '/nix/store/xn7rx42hd8m88fcxhka67blmg9zp7ny9-kvdo-8.2.1.6.drv' failed with exit code 2;
       last 10 log lines:
       > /nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/include/linux/blkdev.h:1481:50: note: expected 'void *' but argument is of type 'int'
       >  1481 | void blkdev_put(struct block_device *bdev, void *holder);
       >       |                                            ~~~~~~^~~~~~
       > cc1: all warnings being treated as errors
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/vdo/io-factory.o] Error 1
       > make[3]: *** Waiting for unfinished jobs....
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:480: /build/source/vdo] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       For full logs, run 'nix log /nix/store/xn7rx42hd8m88fcxhka67blmg9zp7ny9-kvdo-8.2.1.6.drv'.
error: builder for '/nix/store/3yb3mq0avar4pbspnkcrajh3ynv11w4x-mba6x_bl-unstable-2017-12-30.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/mba6x_bl.c:325:9: error: implicit declaration of function 'acpi_video_set_dmi_backlight_type'; did you mean 'acpi_video_get_backlight_type'? [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Werror=implicit-function-declaration8;;]                                                                               
       >   325 |         acpi_video_set_dmi_backlight_type(acpi_backlight_vendor);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       >       |         acpi_video_get_backlight_type
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/mba6x_bl.o] Error 1
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:8: all] Error 2
       For full logs, run 'nix log /nix/store/3yb3mq0avar4pbspnkcrajh3ynv11w4x-mba6x_bl-unstable-2017-12-30.drv'.
error: builder for '/nix/store/7zmhcayi3z4d3asjmkpb52p6h4qy71xy-mbp2018-bridge-drv-2020-01-31.drv' failed with exit code 2;
       last 10 log lines:
       >   393 |     bce_class = class_create(THIS_MODULE, "bce");
       >       |                 ^~~~~~~~~~~~
       > /nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/include/linux/device/class.h:230:29: note: declared here
       >   230 | struct class * __must_check class_create(const char *name);
       >       |                             ^~~~~~~~~~~~
       > cc1: some warnings being treated as errors
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/pci.o] Error 1
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       For full logs, run 'nix log /nix/store/7zmhcayi3z4d3asjmkpb52p6h4qy71xy-mbp2018-bridge-drv-2020-01-31.drv'.
error: builder for '/nix/store/cnc7p160z7m8v3ilcnysjvm8anrr2gli-prl-tools-19.0.0-54570.drv' failed with exit code 2;
       last 10 log lines:
       > /nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/include/linux/mm.h:2430:6: note: declared here
       >  2430 | long get_user_pages(unsigned long start, unsigned long nr_pages,
       >       |      ^~~~~~~~~~~~~~
       > make[4]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/prl-tools-build/kmods/prl_tg/Toolgate/Guest/Linux/prl_tg/prltg_call.o] Error 1
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/prl-tools-build/kmods/prl_tg/Toolgate/Guest/Linux/prl_tg] Error 2
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make[1]: *** [Makefile:44: prl_tg] Error 2
       > make[1]: Leaving directory '/build/prl-tools-build/kmods/prl_tg/Toolgate/Guest/Linux/prl_tg'
       > make: *** [Makefile.kmods:48: compile] Error 2
       For full logs, run 'nix log /nix/store/cnc7p160z7m8v3ilcnysjvm8anrr2gli-prl-tools-19.0.0-54570.drv'.
error: builder for '/nix/store/glnq27nrxwdgxdy2g1vb5ir9apqidrxy-rtl8821cu-6.5-unstable-2023-04-28.drv' failed with exit code 2;
       last 10 log lines:
       >   CC [M]  /build/source/hal/hal_intf.o
       >   CC [M]  /build/source/hal/hal_com.o
       > cc1: some warnings being treated as errors
       >   CC [M]  /build/source/hal/hal_com_phycfg.o
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/os_dep/linux/ioctl_cfg80211.o] Error 1
       > make[3]: *** Waiting for unfinished jobs....
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:2501: modules] Error 2
       For full logs, run 'nix log /nix/store/glnq27nrxwdgxdy2g1vb5ir9apqidrxy-rtl8821cu-6.5-unstable-2023-04-28.drv'.
error: builder for '/nix/store/l2w0pik8j3q4xrifvamn83dqp90yx04f-system76-acpi-module-1.0.2-6.5.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/system76_acpi.c:566:27: error: initialization of 'void (*)(struct acpi_device *)' from incompatible pointer type 'int (*)(struct acpi_device *)' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wincompatible-pointer-types-Werror=incompatible-pointer-types8;;]                                                                                 
       >   566 |                 .remove = system76_remove,
       >       |                           ^~~~~~~~~~~~~~~
       > /build/source/system76_acpi.c:566:27: note: (near initialization for 'system76_driver.ops.remove')
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/system76_acpi.o] Error 1
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:5: all] Error 2
       For full logs, run 'nix log /nix/store/l2w0pik8j3q4xrifvamn83dqp90yx04f-system76-acpi-module-1.0.2-6.5.drv'.
error: builder for '/nix/store/zh877s5cp8sj5dz6lwsbak6gml2kjdg7-virtio_vmmci.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/virtio_vmmci.c:285:28: warning: assignment to 'struct ctl_table_header *' from 'int' makes pointer from integer without a cast [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wint-conversion-Wint-conversion8;;]                                                                                                                                 
       >   285 |         vmmci_table_header = register_sysctl_table(&vmmci_table);
       >       |                            ^
       > cc1: some warnings being treated as errors
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/source/virtio_vmmci.o] Error 1
       > make[3]: *** Waiting for unfinished jobs....
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source] Error 2
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make: *** [Makefile:14: module] Error 2
       For full logs, run 'nix log /nix/store/zh877s5cp8sj5dz6lwsbak6gml2kjdg7-virtio_vmmci.drv'.
error: builder for '/nix/store/kfzvdpyv7f6hjdpc0a11ggymkncavcyd-vmware-modules-17.0.0-6.5.drv' failed with exit code 2;
       last 10 log lines:
       > make[1]: *** [Makefile:117: vmmon.ko] Error 2
       > make[1]: Leaving directory '/build/source/vmmon-only'
       > make: *** [Makefile:21: vmmon-only] Error 2
       > make: *** Waiting for unfinished jobs....
       > make[3]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/source/vmnet-only] Error 2
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make[2]: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > make[1]: *** [Makefile:117: vmnet.ko] Error 2
       > make[1]: Leaving directory '/build/source/vmnet-only'
       > make: *** [Makefile:21: vmnet-only] Error 2
       For full logs, run 'nix log /nix/store/kfzvdpyv7f6hjdpc0a11ggymkncavcyd-vmware-modules-17.0.0-6.5.drv'.
error: builder for '/nix/store/7a62c3xxrp4wc3m52y48qajb2d9jkcvj-dpdk-22.11.1-6.5.drv' failed with exit code 1;
       last 10 log lines:
       > make[2]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/scripts/Makefile.build:243: /build/dpdk-stable-22.11.1/build/kernel/linux/kni/kni_misc.o] Error 1
       > make[1]: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:2032: /build/dpdk-stable-22.11.1/build/kernel/linux/kni] Error 2
       > make: *** [/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/source/Makefile:234: __sub-make] Error 2
       > make: Leaving directory '/nix/store/vg73f9k8mg1ll9gwbdlz5xdm89kv5zzq-linux-6.5-dev/lib/modules/6.5.0/build'
       > [3345/3346] Generating doc/api/doxygen with a custom command
       > warning: Tag 'HTML_TIMESTAMP' at line 102 of file 'doc/api/doxy-api.conf' has become obsolete.
       >          To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"
       > [3346/3346] Generating doc/guides/html_guides with a custom command
       > Install the sphinx ReadTheDocs theme for improved html documentation layout: https://sphinx-rtd-theme.readthedocs.io/
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/7a62c3xxrp4wc3m52y48qajb2d9jkcvj-dpdk-22.11.1-6.5.drv'.
error: builder for '/nix/store/kl08q1g3mr7hj5gg2gx2h8r7gsdqamfw-openafs-1.8.10-6.5.0.drv' failed with exit code 2;
       last 10 log lines:
       > FAILURE: make exit code 2
       > make[4]: *** [Makefile.afs:283: libafs.ko] Error 1
       > make[4]: Leaving directory '/build/openafs-1.8.10/src/libafs/MODLOAD-6.5.0-MP'
       > make[3]: *** [Makefile:188: linux_compdirs] Error 2
       > make[3]: Leaving directory '/build/openafs-1.8.10/src/libafs'
       > make[2]: *** [Makefile:463: libafs] Error 2
       > make[2]: Leaving directory '/build/openafs-1.8.10'
       > make[1]: *** [Makefile:650: build] Error 2
       > make[1]: Leaving directory '/build/openafs-1.8.10'
       > make: *** [Makefile:38: only_libafs] Error 2
       For full logs, run 'nix log /nix/store/kl08q1g3mr7hj5gg2gx2h8r7gsdqamfw-openafs-1.8.10-6.5.0.drv'.
error: 16 dependencies of derivation '/nix/store/pmmjsdbx93fihqnykzv4dn2a99am0yk9-env.drv' failed to build
error: 1 dependencies of derivation '/nix/store/75nyn6whrnpjz68piaw6y7x9wj4jkc6w-review-shell.drv' failed to build

@Madouura
Copy link
Copy Markdown
Contributor Author

Madouura commented Sep 8, 2023

The problem with the bcachefsEncrypted test might be some sort of missing module, as it happens before the passphrase can be entered, but again, works fine on my hardware.

Log
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.415014] Trying to unpack rootfs image as initramfs...
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.418606] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x7350bad78bd, max_idle_ns: 881591017007 ns
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.421812] Initialise system trusted keyrings
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.424727] workingset: timestamp_bits=40 max_order=18 bucket_order=0
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.425640] zbud: loaded
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.426276] Key type asymmetric registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.426895] Asymmetric key parser 'x509' registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.427612] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252)
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.431526] io scheduler mq-deadline registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.432173] io scheduler kyber registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.436712] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.437749] 00:04: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 16550A
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.439397] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.440476] drop_monitor: Initializing network drop monitor service
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.460351] NET: Registered PF_INET6 protocol family
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.492837] Freeing initrd memory: 14060K
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.493764] Segment Routing with IPv6
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.494320] In-situ OAM (IOAM) with IPv6
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.495108] IPI shorthand broadcast: enabled
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.497371] sched_clock: Marking stable (361013058, 135490020)->(537103830, -40600752)
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.498634] registered taskstats version 1
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.499269] Loading compiled-in X.509 certificates
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.501943] Key type .fscrypt registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.502534] Key type fscrypt-provisioning registered
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.503361] clk: Disabling unused clocks
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.504824] Freeing unused decrypted memory: 2036K
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.505873] Freeing unused kernel image (initmem) memory: 2928K
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.506696] Write protecting the kernel read-only data: 24576k
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.507746] Freeing unused kernel image (rodata/data gap) memory: 1092K
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.552528] x86/mm: Checked W+X mappings: passed, no W+X pages found.
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.553398] Run /init as init process
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.604163] device-mapper: ioctl: 4.48.0-ioctl (2023-03-01) initialised: dm-devel@redhat.com
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.665828] rtc_cmos 00:05: RTC can wake from S4
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.672342] rtc_cmos 00:05: registered as rtc0
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.674312] rtc_cmos 00:05: alarms up to one day, y3k, 242 bytes nvram, hpet irqs
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.675399] i8042: PNP: PS/2 Controller [PNP0303:KBD,PNP0f13:MOU] at 0x60,0x64 irq 1,12
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.682636] Floppy drive(s): fd0 is 2.88M AMI BIOS
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.688186] serio: i8042 KBD port at 0x60,0x64 irq 1
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.694020] serio: i8042 AUX port at 0x60,0x64 irq 12
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.695037] FDC 0 is a S82078B
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.727941] SCSI subsystem initialized
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.773044] input: AT Translated Set 2 keyboard as /devices/platform/i8042/serio0/input/input0
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.774803] scsi host0: ata_piix
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.776143] ACPI: \_SB_.LNKC: Enabled at IRQ 11
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.781532] scsi host1: ata_piix
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.782087] ata1: PATA max MWDMA2 cmd 0x1f0 ctl 0x3f6 bmdma 0xc100 irq 14
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.783017] ata2: PATA max MWDMA2 cmd 0x170 ctl 0x376 bmdma 0xc108 irq 15
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.809363] ACPI: \_SB_.LNKD: Enabled at IRQ 10
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.866435] ACPI: \_SB_.LNKA: Enabled at IRQ 10
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.896718] ACPI: \_SB_.LNKB: Enabled at IRQ 11
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.937609] ata2: found unknown device (class 0)
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.938808] ata2.00: ATAPI: QEMU DVD-ROM, 2.5+, max UDMA/100
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.940359] scsi 1:0:0:0: CD-ROM            QEMU     QEMU DVD-ROM     2.5+ PQ: 0 ANSI: 5
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.976081] virtio_blk virtio3: 1/0/0 default/read/poll queues
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.977411] virtio_blk virtio3: [vda] 16777216 512-byte logical blocks (8.59 GB/8.00 GiB)
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.988696]  vda: vda1 vda2 vda3
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.991042] sr 1:0:0:0: [sr0] scsi3-mmc drive: 4x/4x cd/rw xa/form2 tray
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [    0.992089] cdrom: Uniform CD-ROM driver Revision: 3.20
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.284489] raid6: avx2x4   gen() 35995 MB/s
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.301489] raid6: avx2x2   gen() 31245 MB/s
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.318488] raid6: avx2x1   gen() 28992 MB/s
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.319110] raid6: using algorithm avx2x4 gen() 35995 MB/s
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.336488] raid6: .... xor() 6512 MB/s, rmw enabled
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.337188] raid6: using avx2x2 recovery algorithm
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.341039] xor: automatically using best checksumming function   avx
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.423261] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.424346] CPU: 0 PID: 1 Comm: init Not tainted 6.5.1 #1-NixOS
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.425161] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.426687] Call Trace:
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.427094]  <TASK>
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.427455]  dump_stack_lvl+0x47/0x60
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.428008]  panic+0x321/0x340
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.428483]  ? srso_alias_return_thunk+0x5/0x7f
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.429136]  do_exit+0x959/0xad0
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.429632]  ? handle_mm_fault+0x9e/0x350
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.430227]  do_group_exit+0x31/0x80
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.430764]  __x64_sys_exit_group+0x18/0x20
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.431372]  do_syscall_64+0x3e/0x90
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.431913]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.432621] RIP: 0033:0x7f29370de2ed
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.433159] Code: 01 48 83 c8 ff c3 0f 1f 80 00 00 00 00 f3 0f 1e fa 48 8b 35 1d 4b 10 00 ba e7 00 00 00 eb 07 66 0f 1f 44 00 00 f4 89 d0 0f 05 <48> 3d 00 f0 ff ff 76 f3 f7 d8 64 89 06 eb ec 0f 1f 40 00 f3 0f 1e
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.435598] RSP: 002b:00007ffe38f26538 EFLAGS: 00000202 ORIG_RAX: 00000000000000e7
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.436663] RAX: ffffffffffffffda RBX: 00007ffe38f27f04 RCX: 00007f29370de2ed
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.437618] RDX: 00000000000000e7 RSI: ffffffffffffff88 RDI: 0000000000000001
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.438574] RBP: 0000000000000004 R08: 00007ffe38f26540 R09: 0000000000000004
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.439528] R10: 2c235966ea7f85ca R11: 0000000000000202 R12: 0000000000000000
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.440483] R13: 00007ffe38f26920 R14: 0000000000000000 R15: 00007f293732e000
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.441441]  </TASK>
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.441873] Kernel Offset: 0x10800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
vm-test-run-installer-bcachefs-encrypted> boot-after-install # [   22.443316] Rebooting in 1 seconds..
vm-test-run-installer-bcachefs-encrypted> cleanup
vm-test-run-installer-bcachefs-encrypted> (finished: cleanup, in 0.01 seconds)
vm-test-run-installer-bcachefs-encrypted> Traceback (most recent call last):
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/bin/.nixos-test-driver-wrapped", line 9, in <module>
vm-test-run-installer-bcachefs-encrypted>     sys.exit(main())
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/__init__.py", line 118, in main
vm-test-run-installer-bcachefs-encrypted>     driver.run_tests()
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/driver.py", line 147, in run_tests
vm-test-run-installer-bcachefs-encrypted>     self.test_script()
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/driver.py", line 143, in test_script
vm-test-run-installer-bcachefs-encrypted>     exec(self.tests, symbols, None)
vm-test-run-installer-bcachefs-encrypted>   File "<string>", line 90, in <module>
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 1000, in wait_for_text
vm-test-run-installer-bcachefs-encrypted>     retry(screen_matches)
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 127, in retry
vm-test-run-installer-bcachefs-encrypted>     if fn(False):
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 989, in screen_matches
vm-test-run-installer-bcachefs-encrypted>     variants = self.get_screen_text_variants()
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 964, in get_screen_text_variants
vm-test-run-installer-bcachefs-encrypted>     return self._get_screen_text_variants([0, 1, 2])
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 949, in _get_screen_text_variants
vm-test-run-installer-bcachefs-encrypted>     self.send_monitor_command(f"screendump {screenshot_path}")
vm-test-run-installer-bcachefs-encrypted>   File "/nix/store/6r0xcazpyd0c1y3948yaydglhkqbrhky-nixos-test-driver-1.1/lib/python3.10/site-packages/test_driver/machine.py", line 426, in send_monitor_command
vm-test-run-installer-bcachefs-encrypted>     self.monitor.send(message)
vm-test-run-installer-bcachefs-encrypted> BrokenPipeError: [Errno 32] Broken pipe

@Madouura Madouura changed the title bcachefs: 2023-06-28 -> 2023-08-28 bcachefs: 2023-06-28 -> 2023-09-08 Sep 8, 2023
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 11, 2023

Testing in progress: Mic92/dotfiles#880

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 11, 2023

Interestingly I am getting on my ci a different checksum now: https://buildbot.thalheim.io/#/builders/52/builds/178

Can you reproduce this?

@YellowOnion
Copy link
Copy Markdown
Contributor

YellowOnion commented Sep 11, 2023

Not sure if it's related to the above crash, but we have a bunch of missing modules from initrd like crc32c:

$ ❯ grep -E 'select|depends' Kconfig
        depends on BLOCK
        select EXPORTFS
        select CLOSURES
        select LIBCRC32C
        select CRC64
        select FS_POSIX_ACL
        select LZ4_COMPRESS
        select LZ4_DECOMPRESS
        select LZ4HC_COMPRESS
        select LZ4HC_DECOMPRESS
        select ZLIB_DEFLATE
        select ZLIB_INFLATE
        select ZSTD_COMPRESS
        select ZSTD_DECOMPRESS
        select CRYPTO_SHA256
        select CRYPTO_CHACHA20
        select CRYPTO_POLY1305
        select KEYS
        select RAID6_PQ
        select XOR_BLOCKS
        select XXHASH
        select SRCU
        select SYMBOLIC_ERRNAME
        select MEAN_AND_VARIANCE

We could also expand the test suite to include some variations, the new mount wrapper supports UUIDs, and they currently break some stuff in systemd:

Sep 09 12:05:44 Purple-Sunrise systemd[1]: Failed to start Remount Root and Kernel File Systems.
Sep 09 12:05:44 Purple-Sunrise systemd[1]: systemd-remount-fs.service: Failed with result 'exit-code'.
Sep 09 12:05:44 Purple-Sunrise systemd[1]: systemd-remount-fs.service: Main process exited, code=exited, status=1/FAILURE
Sep 09 12:05:44 Purple-Sunrise systemd-remount-fs[653]: /nix/store/vmm9fdvcw59s6yr8imjpkhs1b0spjnfc-util-linux-minimal-2.38.1-bin/bin/mount for / exited with exit status >
Sep 09 12:05:44 Purple-Sunrise systemd-remount-fs[655]: mount: /: can't find UUID=927137d3-8864-4756-9c7e-3b9d1efff07b.

@Madouura
Copy link
Copy Markdown
Contributor Author

Not sure if it's related to the above crash, but we have a bunch of missing modules from initrd like crc32c:

$ ❯ grep -E 'select|depends' Kconfig
        depends on BLOCK
        select EXPORTFS
        select CLOSURES
        select LIBCRC32C
        select CRC64
        select FS_POSIX_ACL
        select LZ4_COMPRESS
        select LZ4_DECOMPRESS
        select LZ4HC_COMPRESS
        select LZ4HC_DECOMPRESS
        select ZLIB_DEFLATE
        select ZLIB_INFLATE
        select ZSTD_COMPRESS
        select ZSTD_DECOMPRESS
        select CRYPTO_SHA256
        select CRYPTO_CHACHA20
        select CRYPTO_POLY1305
        select KEYS
        select RAID6_PQ
        select XOR_BLOCKS
        select XXHASH
        select SRCU
        select SYMBOLIC_ERRNAME
        select MEAN_AND_VARIANCE

We could also expand the test suite to include some variations, the new mount wrapper supports UUIDs, and they currently break some stuff in systemd:

Sep 09 12:05:44 Purple-Sunrise systemd[1]: Failed to start Remount Root and Kernel File Systems.
Sep 09 12:05:44 Purple-Sunrise systemd[1]: systemd-remount-fs.service: Failed with result 'exit-code'.
Sep 09 12:05:44 Purple-Sunrise systemd[1]: systemd-remount-fs.service: Main process exited, code=exited, status=1/FAILURE
Sep 09 12:05:44 Purple-Sunrise systemd-remount-fs[653]: /nix/store/vmm9fdvcw59s6yr8imjpkhs1b0spjnfc-util-linux-minimal-2.38.1-bin/bin/mount for / exited with exit status >
Sep 09 12:05:44 Purple-Sunrise systemd-remount-fs[655]: mount: /: can't find UUID=927137d3-8864-4756-9c7e-3b9d1efff07b.

That is directly related I believe, since bcachefs used crc32 by default. I'll investigate it.

@YellowOnion
Copy link
Copy Markdown
Contributor

That is directly related I believe, since bcachefs used crc32 by default. I'll investigate it.

bcachefs is smart and uses crc32c for plaintext blocks, but if encryption is enabled it skips over the CRC's because it's redundant with authentication codes like poly1305, so I'm somewhat skeptical it's explicit crc32c, but it could be one of the others, though crc32c might be used for superblocks or something else irrespective of encryption.

@Madouura
Copy link
Copy Markdown
Contributor Author

Tried adding some different modules to the initrd for the test but not working unfortunately.
Here's a little patch for future use if needed though.
installer-extra-initrd-modules.txt

@Madouura Madouura changed the title bcachefs: 2023-06-28 -> 2023-09-08 bcachefs: 2023-06-28 -> 2023-09-11 Sep 12, 2023
@Madouura
Copy link
Copy Markdown
Contributor Author

Interestingly I am getting on my ci a different checksum now: https://buildbot.thalheim.io/#/builders/52/builds/178

Can you reproduce this?

I updated so maybe just never got the chance to reproduce this, but it hasn't occurred on the new commit.

@YellowOnion
Copy link
Copy Markdown
Contributor

It just occurred to me that none of the initrd stuff matters as the test only modprobes after boot, only really applies to rootfs (like my machine).

I made a patch that adds all modules: YellowOnion@d7db5b5

I'm not sure how to test initrd though, I use lz4 so I could probably test that part once I get my vanilla kernel working.

@Madouura
Copy link
Copy Markdown
Contributor Author

Madouura commented Sep 12, 2023

Tried your patch with the bcachefsEncrypted test and unfortunately still no luck.
Like before, encryption and all the options work fine on my hardware, but that one test just won't budge.
At least, it seems to be down to just that test and not bcachefs on nixos as a whole.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 12, 2023

Do you think it would be sensible to update the list of modules anyway?

      boot.initrd.availableKernelModules = [
        "bcachefs"
        "sha256" "chacha20" "poly1305" # encrypted devices
        "crc32c" "crc64" "xxhash" # checksums
        "lz4" "lz4hc" "zstd" # compression
        "raid6_pq" "xor" # erasure coding
        "mean_and_variance"
      ];

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 12, 2023

Even after dropping the encryption from this test, it still doesn't work.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 12, 2023

@ofborg test bcachefsSimple

@Madouura
Copy link
Copy Markdown
Contributor Author

Madouura commented Sep 12, 2023

Between the last test I did and the current commit is a few commits on bcachefs and a rebase on newest master.
Interesting, bcachefsSimple is giving me the same error now as bcachefsEncrypted, when it did not do this before, and still works on my hardware... However, bcachefsMulti still works.
The kernel error seems to be strangely repeatable, but also very random... A race condition somewhere?

@Madouura
Copy link
Copy Markdown
Contributor Author

Do you think it would be sensible to update the list of modules anyway?

      boot.initrd.availableKernelModules = [
        "bcachefs"
        "sha256" "chacha20" "poly1305" # encrypted devices
        "crc32c" "crc64" "xxhash" # checksums
        "lz4" "lz4hc" "zstd" # compression
        "raid6_pq" "xor" # erasure coding
        "mean_and_variance"
      ];

I honestly don't see why not. I'll add it in a future commit.

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 12, 2023

This is actually breaking before the init is even executed in the initialization of the kernel. Maybe when loading the bcachefs kernel module?

@Madouura
Copy link
Copy Markdown
Contributor Author

Madouura commented Sep 12, 2023

This is actually breaking before the init is even executed in the initialization of the kernel. Maybe when loading the bcachefs kernel module?

That could be it, but I'm unsure as to why some tests work and others don't. Was there any new nix-specific patches to the base kernel in nixpkgs?

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 13, 2023

This is actually breaking before the init is even executed in the initialization of the kernel. Maybe when loading the bcachefs kernel module?

That could be it, but I'm unsure as to why some tests work and others don't. Was there any new nix-specific patches to the base kernel in nixpkgs?

It seems to be mainly an issue when it's used as a root filesystem and this code path is active:

boot.initrd.availableKernelModules = [ "bcachefs" "sha256" "chacha20" "poly1305" ];

Maybe the bug gets triggered if the bcachefs module is loaded early? The patches in NixOS are relatively boring: https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/kernel/patches.nix

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 13, 2023

After rebasing, I am able to get in stage1 for bcachefsSimple but than it crashes a bit later. Still I have the feeling if we merge this it will result unbootable systems. bcachefs now was added to linux-next. Maybe we can soonish see a linux_testing update that actually has bcachefs...

@Madouura
Copy link
Copy Markdown
Contributor Author

After rebasing, I am able to get in stage1 for bcachefsSimple but than it crashes a bit later. Still I have the feeling if we merge this it will result unbootable systems. bcachefs now was added to linux-next. Maybe we can soonish see a linux_testing update that actually has bcachefs...

I agree, we shouldn't merge this yet. While I can't rule out it's not just a problem with the VM environment, since this works on my hardware, I don't think it's safe to merge.
What's interesting is if it's because it's a root filesystem, and the bcachefsMulti test and my own config works, we can evaluate that the problem is related to some code path in bcachefs where we only have a single root system and not a multi-device root.

@Madouura
Copy link
Copy Markdown
Contributor Author

Bingo! The problem lies within there only being a single-device root.
Tested bcachefsMulti modified to use encryption and it works.
installer-bcachefs-multi-encrypted.txt
Now, the question is whether the problem is on our side or bcachefs' side...

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 13, 2023
@Madouura Madouura changed the title bcachefs: 2023-06-28 -> 2023-09-11 bcachefs: 2023-06-28 -> 2023-09-12 Sep 13, 2023
@chayleaf
Copy link
Copy Markdown
Contributor

can you try bisecting this?

@Madouura
Copy link
Copy Markdown
Contributor Author

Madouura commented Sep 15, 2023

can you try bisecting this?

The last time bcachefsSimple (but not bcachefsEncrypted) worked was koverstreet/bcachefs@e48b2d1.
I have a strong feeling this isn't a nixpkgs issue, thus koverstreet/bcachefs#591.

@chayleaf
Copy link
Copy Markdown
Contributor

So koverstreet/bcachefs@d459d9c broke it? In that case the offending commit needs to be reported upstream

@Madouura
Copy link
Copy Markdown
Contributor Author

So koverstreet/bcachefs@d459d9c broke it? In that case the offending commit needs to be reported upstream

I'm unsure, and do not have any experience with the codebase so I'm not going to start listing commits I suspect.

@YellowOnion
Copy link
Copy Markdown
Contributor

@Madouura I don't think it matters, a bisect is a bisect, always helpful.

@KyleSanderson
Copy link
Copy Markdown

enabling the feature kicks you back to 6.1 in January 2023. Crypto doesn't work at all on a single device install (fails to find the key) without additional packages present.

@YellowOnion
Copy link
Copy Markdown
Contributor

I have a 6.5 version here if anyone wants to try testing it with encryption https://github.com/YellowOnion/nur-bcachefs/

it's also worth mentioning that bcachefs is now in linux-next. So we can probably get rid of the extra kernel with 6.7.

@YellowOnion
Copy link
Copy Markdown
Contributor

machine #   fileSystems."/" =
machine #     { device = "/dev/disk/by-uuid/e4d167e8-92e1-40fe-bfde-c9d2d0a77b88";
machine #       fsType = "bcachefs";
machine #     };
machine #

Is this the cause? bcachefs doesn't use by-uuid on my system.

When I run the test I get this (with the old bcachefs-tools)

Has me thinking the issue is just UUID detection issues explicity for bcachefs and the installer.

boot-after-install # starting device mapper and LVM...
boot-after-install # waiting for device /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae to appear.......................
boot-after-install # Timed out waiting for device /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae, trying to mount anyway.
boot-after-install # mounting /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae on /...
boot-after-install # [   21.973600] raid6: avx2x4   gen() 40388 MB/s
boot-after-install # [   21.990599] raid6: avx2x2   gen() 33165 MB/s
boot-after-install # [   22.007600] raid6: avx2x1   gen() 30099 MB/s
boot-after-install # [   22.007888] raid6: using algorithm avx2x4 gen() 40388 MB/s
boot-after-install # [   22.024600] raid6: .... xor() 7465 MB/s, rmw enabled
boot-after-install # [   22.024919] raid6: using avx2x2 recovery algorithm
boot-after-install # [   22.028340] xor: automatically using best checksumming function   avx
boot-after-install # ERROR - bcachefs_rust::cmd_mount: Fatal error: "No such file or directory"
boot-after-install # mount: can't find /mnt-root/ in /proc/mounts
boot-after-install # stage 2 init script (/mnt-root//nix/store/rx9r100slc17apqafaj8wksi5l05xizv-nixos-system-thatworked-23.11pre-git/init) not found
boot-after-install # [   23.154552] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
boot-after-install # [   23.155041] CPU: 0 PID: 1 Comm: init Not tainted 6.5.4 #1-NixOS
boot-after-install # [   23.155427] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014
boot-after-install # [   23.156168] Call Trace:
boot-after-install # [   23.156345]  <TASK>
boot-after-install # [   23.156534]  dump_stack_lvl+0x47/0x60
boot-after-install # [   23.156816]  panic+0x323/0x340
boot-after-install # [   23.157037]  ? srso_alias_return_thunk+0x5/0x7f
boot-after-install # [   23.157361]  do_exit+0x959/0xad0
boot-after-install # [   23.157603]  ? handle_mm_fault+0x9e/0x350
boot-after-install # [   23.157888]  do_group_exit+0x31/0x80
boot-after-install # [   23.158145]  __x64_sys_exit_group+0x18/0x20
boot-after-install # [   23.158444]  do_syscall_64+0x3e/0x90
boot-after-install # [   23.158685]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
boot-after-install # [   23.159051] RIP: 0033:0x7f106ec792ed
boot-after-install # [   23.159305] Code: 01 48 83 c8 ff c3 0f 1f 80 00 00 00 00 f3 0f 1e fa 48 8b 35 1d 4b 10 00 ba e7 00 00 00 eb 07 66 0f 1f 44 00 00 f4 89 d0 0f 05 <48> 3d 00 f0 ff ff 76 f3 f7 d8 64 89 06 eb ec 0f 1f 40 00 f3 0f 1e
boot-after-install # [   23.160517] RSP: 002b:00007ffdfb750d48 EFLAGS: 00000202 ORIG_RAX: 00000000000000e7
boot-after-install # [   23.160988] RAX: ffffffffffffffda RBX: 00007ffdfb751f04 RCX: 00007f106ec792ed
boot-after-install # [   23.161467] RDX: 00000000000000e7 RSI: ffffffffffffff88 RDI: 0000000000000001
boot-after-install # [   23.161946] RBP: 0000000000000004 R08: 00007ffdfb750d50 R09: 0000000000000004
boot-after-install # [   23.162422] R10: e2514faf19dad5ca R11: 0000000000000202 R12: 0000000000000000
boot-after-install # [   23.162891] R13: 00007ffdfb751130 R14: 0000000000000000 R15: 00007f106eec9000
boot-after-install # [   23.163365]  </TASK>

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 21, 2023

machine #   fileSystems."/" =
machine #     { device = "/dev/disk/by-uuid/e4d167e8-92e1-40fe-bfde-c9d2d0a77b88";
machine #       fsType = "bcachefs";
machine #     };
machine #

Is this the cause? bcachefs doesn't use by-uuid on my system.

When I run the test I get this (with the old bcachefs-tools)

Has me thinking the issue is just UUID detection issues explicity for bcachefs and the installer.

boot-after-install # starting device mapper and LVM...
boot-after-install # waiting for device /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae to appear.......................
boot-after-install # Timed out waiting for device /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae, trying to mount anyway.
boot-after-install # mounting /dev/disk/by-uuid/fd03e3b6-e15c-4c3a-a0de-d4fd7255f7ae on /...
boot-after-install # [   21.973600] raid6: avx2x4   gen() 40388 MB/s
boot-after-install # [   21.990599] raid6: avx2x2   gen() 33165 MB/s
boot-after-install # [   22.007600] raid6: avx2x1   gen() 30099 MB/s
boot-after-install # [   22.007888] raid6: using algorithm avx2x4 gen() 40388 MB/s
boot-after-install # [   22.024600] raid6: .... xor() 7465 MB/s, rmw enabled
boot-after-install # [   22.024919] raid6: using avx2x2 recovery algorithm
boot-after-install # [   22.028340] xor: automatically using best checksumming function   avx
boot-after-install # ERROR - bcachefs_rust::cmd_mount: Fatal error: "No such file or directory"
boot-after-install # mount: can't find /mnt-root/ in /proc/mounts
boot-after-install # stage 2 init script (/mnt-root//nix/store/rx9r100slc17apqafaj8wksi5l05xizv-nixos-system-thatworked-23.11pre-git/init) not found
boot-after-install # [   23.154552] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100
boot-after-install # [   23.155041] CPU: 0 PID: 1 Comm: init Not tainted 6.5.4 #1-NixOS
boot-after-install # [   23.155427] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014
boot-after-install # [   23.156168] Call Trace:
boot-after-install # [   23.156345]  <TASK>
boot-after-install # [   23.156534]  dump_stack_lvl+0x47/0x60
boot-after-install # [   23.156816]  panic+0x323/0x340
boot-after-install # [   23.157037]  ? srso_alias_return_thunk+0x5/0x7f
boot-after-install # [   23.157361]  do_exit+0x959/0xad0
boot-after-install # [   23.157603]  ? handle_mm_fault+0x9e/0x350
boot-after-install # [   23.157888]  do_group_exit+0x31/0x80
boot-after-install # [   23.158145]  __x64_sys_exit_group+0x18/0x20
boot-after-install # [   23.158444]  do_syscall_64+0x3e/0x90
boot-after-install # [   23.158685]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
boot-after-install # [   23.159051] RIP: 0033:0x7f106ec792ed
boot-after-install # [   23.159305] Code: 01 48 83 c8 ff c3 0f 1f 80 00 00 00 00 f3 0f 1e fa 48 8b 35 1d 4b 10 00 ba e7 00 00 00 eb 07 66 0f 1f 44 00 00 f4 89 d0 0f 05 <48> 3d 00 f0 ff ff 76 f3 f7 d8 64 89 06 eb ec 0f 1f 40 00 f3 0f 1e
boot-after-install # [   23.160517] RSP: 002b:00007ffdfb750d48 EFLAGS: 00000202 ORIG_RAX: 00000000000000e7
boot-after-install # [   23.160988] RAX: ffffffffffffffda RBX: 00007ffdfb751f04 RCX: 00007f106ec792ed
boot-after-install # [   23.161467] RDX: 00000000000000e7 RSI: ffffffffffffff88 RDI: 0000000000000001
boot-after-install # [   23.161946] RBP: 0000000000000004 R08: 00007ffdfb750d50 R09: 0000000000000004
boot-after-install # [   23.162422] R10: e2514faf19dad5ca R11: 0000000000000202 R12: 0000000000000000
boot-after-install # [   23.162891] R13: 00007ffdfb751130 R14: 0000000000000000 R15: 00007f106eec9000
boot-after-install # [   23.163365]  </TASK>

Looks like regression still. Could create the uuid symlink ourself until upstream fixes that?

On my system I still have that for bcachefs:

[root@eva:~]# ls -la /dev/disk/by-uuid/
total 0
drwxr-xr-x 2 root root 80 Sep 5 17:21 .
drwxr-xr-x 8 root root 160 Sep 5 17:21 ..
lrwxrwxrwx 1 root root 10 Sep 5 17:21 0AF4-ECDC -> ../../sda1
lrwxrwxrwx 1 root root 10 Sep 5 17:21 8fafbe10-30b7-4f1a-8acd-eb44266aed3d -> ../../sda2

[root@eva:~]# uname -a
Linux eva 6.4.14 #1-NixOS SMP PREEMPT_DYNAMIC Sat Sep 2 07:14:38 UTC 2023 x86_64 GNU/Linux

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Sep 21, 2023

So you are thinking it generates the wrong uuid during boot? You already progressed further than our old attempts. What version of bcachefs-tools is compatible with linux-next?

@YellowOnion
Copy link
Copy Markdown
Contributor

YellowOnion commented Sep 22, 2023

@Mic92 I got the system to boot replacing by-uuid with UUID= in the script that generates the initial config but it breaks systemd-remount-fs (not a huge problem), util-linux merged bcachefs patches in april which is why we now use by-uuid instead of raw dev numbers, but it's unstable (really only works with an empty file system), so that's why by-uuid works 50% of the time, so we either need to completely replace util-linux with the one on master, or patch systemd to replace the hard coded reference to mount/umount, neither solution is nice because it requires deep rebuild of the entire OS.

Have to replace util-linux so mount can read fstab correctly, it never delegates to the mount wrapper, and systemd-remount-fs issues a mount -oremount / and I think gets confused. I'm not sure how to debug this to confirm it 100%.

Replacing the symlink can work for single device systems, but I'm unsure what the correct way to manage multi-device systems.

We can also replace systemd-remount-fs with our own unit perhaps that uses the patched mount/umount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants