Skip to content

libicns: 0.8.1 -> unstable-2022-04-10#252255

Merged
toonn merged 1 commit intoNixOS:masterfrom
reckenrode:libicns-fix
Sep 28, 2023
Merged

libicns: 0.8.1 -> unstable-2022-04-10#252255
toonn merged 1 commit intoNixOS:masterfrom
reckenrode:libicns-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

libicns hasn’t had a release in over a decade, but development has continued upstream. Updating removes the need for the openjp2 patch and includes fixes needed to build with newer versions of clang.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

libicns hasn’t had a release in over a decade, but development has
continued upstream. Updating removes the need for the openjp2 patch and
includes fixes needed to build with newer versions of clang.
@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 252255 run on aarch64-darwin 1

3 packages marked as broken and skipped:
  • ares
  • higan
  • kotatogram-desktop
1 package failed to build:
  • mikutter
9 packages built:
  • bsnes-hd
  • grandorgue
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo
  • libicns
  • netbeans
  • rehex

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 30, 2023
@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Aug 30, 2023

Result of nixpkgs-review pr 252255 run on aarch64-linux 1

1 package failed to build:
  • urbanterror
4 packages built:
  • grandorgue
  • libicns
  • netbeans
  • vcv-rack

@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 252255 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • ares
  • higan
2 packages failed to build:
  • kotatogram-desktop
  • mikutter
9 packages built:
  • bsnes-hd
  • grandorgue
  • kitty
  • kitty.kitten
  • kitty.shell_integration
  • kitty.terminfo
  • libicns
  • netbeans
  • rehex

@reckenrode
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 252255 run on x86_64-linux 1

5 packages built:
  • grandorgue
  • libicns
  • netbeans
  • urbanterror
  • vcv-rack

@reckenrode
Copy link
Copy Markdown
Contributor Author

reckenrode commented Aug 30, 2023

Regarding the failures:

  • kotatogram-desktop and mikutter fail due to dependencies (tg_owt and ruby-glib respectively). tg_owt is missing a file (causing cmake to fail), and ruby-glib fails due to a compiler error (static declaration of 'g_bookmark_file_get_type' follows non-static declaration); and
  • urbanterror is not supported on aarch64-linux.

Copy link
Copy Markdown
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toonn toonn merged commit a122b4e into NixOS:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants