Skip to content

gperf_3_0: fix build with clang 16#252245

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
reckenrode:gperf30-fix
Sep 16, 2023
Merged

gperf_3_0: fix build with clang 16#252245
vcunat merged 1 commit intoNixOS:stagingfrom
reckenrode:gperf30-fix

Conversation

@reckenrode
Copy link
Copy Markdown
Contributor

Description of changes

  • Apply the patch used for gperf 3.1 in 58f559c; and
  • Include string.h unconditionally in lib/getopt.c.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

* Apply the patch used for gperf 3.1 in 58f559c; and
* Include `string.h` unconditionally in `lib/getopt.c`.
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Aug 30, 2023
@vcunat vcunat merged commit 52504ab into NixOS:staging Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants