Skip to content

notmuch: don’t check with emacs when withEmacs=false#251735

Merged
marsam merged 1 commit intoNixOS:masterfrom
liff:notmuch-emacs-check
Aug 27, 2023
Merged

notmuch: don’t check with emacs when withEmacs=false#251735
marsam merged 1 commit intoNixOS:masterfrom
liff:notmuch-emacs-check

Conversation

@liff
Copy link
Copy Markdown
Contributor

@liff liff commented Aug 27, 2023

Description of changes

Remove emacs from nativeCheckInputs when the package is built withEmacs = false.

I hit this because I have an overlay that replaces emacs with a Git release (i.e. upcoming v30) and the notmuch’s emacs-dependent tests fail for whatever reason. Removing emacs from check inputs ensures that the test suite cannot find Emacs to test with and will skip the tests.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 27, 2023
@marsam marsam merged commit f814e24 into NixOS:master Aug 27, 2023
@liff liff deleted the notmuch-emacs-check branch November 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants