Skip to content

python3.pkgs.monai-deploy: replace versioneer-518 with versioneer#251065

Merged
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:monai-deploy
Aug 24, 2023
Merged

python3.pkgs.monai-deploy: replace versioneer-518 with versioneer#251065
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:monai-deploy

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 24, 2023

Description of changes

This will fix the build on staging-next, which has stronger build dependency validation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 24, 2023
@ofborg ofborg bot requested a review from bcdarwin August 24, 2023 01:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 24, 2023
@bcdarwin
Copy link
Copy Markdown
Member

Results of nixpkgs-review on x86_64-NixOS:

4 packages built:
python310Packages.monai-deploy python310Packages.monai-deploy.dist python311Packages.monai-deploy python311Packages.monai-deploy.dist

Copy link
Copy Markdown
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@tjni tjni merged commit d1ec06a into NixOS:staging-next Aug 24, 2023
@tjni tjni deleted the monai-deploy branch August 24, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants