Skip to content

[staging-next] python3.pkgs.afdko: add ninja to nativeBuildInputs#250987

Merged
yu-re-ka merged 1 commit intoNixOS:staging-nextfrom
yu-re-ka:afdko-ninja
Aug 23, 2023
Merged

[staging-next] python3.pkgs.afdko: add ninja to nativeBuildInputs#250987
yu-re-ka merged 1 commit intoNixOS:staging-nextfrom
yu-re-ka:afdko-ninja

Conversation

@yu-re-ka
Copy link
Copy Markdown
Contributor

fixes ERROR: Missing dependencies: ninja

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

fixes ERROR: Missing dependencies: ninja
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 23, 2023
@yu-re-ka yu-re-ka changed the title python3.pkgs.afdko: add ninja to nativeBuildInputs [staging-next] python3.pkgs.afdko: add ninja to nativeBuildInputs Aug 23, 2023
@yu-re-ka yu-re-ka requested a review from vcunat August 23, 2023 14:17
@ofborg ofborg bot requested a review from sternenseemann August 23, 2023 15:10
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 23, 2023
@sternenseemann
Copy link
Copy Markdown
Member

@ofborg build python3Packages.afdko

@sternenseemann
Copy link
Copy Markdown
Member

How come this is required now? I couldn't see any obvious changes.

@yu-re-ka yu-re-ka merged commit 1e23ff5 into NixOS:staging-next Aug 23, 2023
@yu-re-ka yu-re-ka deleted the afdko-ninja branch August 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants