Skip to content

viennarna: rename from ViennaRNA#250922

Merged
natsukium merged 2 commits intoNixOS:masterfrom
natsukium:viennarna/update
Sep 13, 2023
Merged

viennarna: rename from ViennaRNA#250922
natsukium merged 2 commits intoNixOS:masterfrom
natsukium:viennarna/update

Conversation

@natsukium
Copy link
Copy Markdown
Member

Description of changes

related to #245383

In the work, I found that we can update it, and the source code is uploaded to the VCS.
I'd like to get the source from GitHub for future updates, but some changes seem to be needed.
Therefore, I'd like to ask the maintainer's opinion before updating the source.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 23, 2023
@natsukium
Copy link
Copy Markdown
Member Author

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • viennarna (python310Packages.viennarna)

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 23, 2023
@ofborg ofborg bot requested a review from prusnak August 23, 2023 08:28
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 23, 2023
@prusnak
Copy link
Copy Markdown
Member

prusnak commented Aug 23, 2023

I'd like to get the source from GitHub for future updates

What's the advantage of using the source from GitHub rather than downloading a tarball from univie.ac.at?

@natsukium
Copy link
Copy Markdown
Member Author

We will receive notifications of version updates and can update automatically.
It would also make it easier to keep track of differences.

@prusnak
Copy link
Copy Markdown
Member

prusnak commented Aug 23, 2023

can update automatically.

OK, that sounds good. If you want to rework the source fetching, feel free to do so. But in that case, please remove me as a maintainer and yourself as one. Thanks!

@natsukium natsukium merged commit acc0ac9 into NixOS:master Sep 13, 2023
@natsukium natsukium deleted the viennarna/update branch September 13, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants