Skip to content

libavif: disable thumbnailer if !build.canExecute host#250900

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

libavif: disable thumbnailer if !build.canExecute host#250900
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 23, 2023

Description of changes

As suggested by @lopsided98 here:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from lopsided98 August 23, 2023 05:07
@lopsided98
Copy link
Copy Markdown
Contributor

lopsided98 commented Aug 23, 2023

Is !canExecute correct? Building the thumbnailer is controlled by meson.is_cross_build(). Also, I already submitted nearly the same PR, except I didn't use canExecute and avoid a mass-rebuild by keeping the blank line: #250813

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 23, 2023 •
edited by ghost
Loading

Also, I already submitted nearly the same PR

Sorry I just noticed that. There is no backlink to it in #250610. Also I already had this commit in my local tree.

except I didn't use canExecute and avoid a mass-rebuild by keeping the blank line: #250813

Clever!

@ghost ghost closed this Aug 23, 2023
@ghost ghost deleted the pr/libavif/cross/thumbnailer branch August 23, 2023 05:15
@ofborg ofborg bot requested a review from mkg20001 August 23, 2023 05:28
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 23, 2023
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lopsided98 lopsided98 Awaiting requested review from lopsided98

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lopsided98