python3.pkgs.python-lsp-server: relax jedi dependency constraint#250824
Merged
tjni merged 1 commit intoNixOS:staging-nextfrom Aug 24, 2023
tjni:python-lsp-server
Merged
python3.pkgs.python-lsp-server: relax jedi dependency constraint#250824tjni merged 1 commit intoNixOS:staging-nextfrom tjni:python-lsp-server
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:python-lsp-server
Conversation
Contributor
Author
|
@ofborg build python310Packages.python-lsp-server python311Packages.python-lsp-server python310Packages.pyls-flake8 python311Packages.pyls-flake8 python310Packages.python-lsp-black python311Packages. python-lsp-black |
Contributor
Author
|
Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This will be needed so that builds continue working on staging-next after 39fc433. In particular,
pyls-flake8andpython-lsp-blackseem to require relaxing this so that their tests pass (for some reason).We could also add
jeditopythonRelaxDepsbut I guess my personal preference is to pull in patches when they exist on upstream. When upstream releases a version with the patch, it is easier to trace and clean up.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)