Skip to content

python3.pkgs.pvlib: add missing build dependencies#250823

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:pvlib
Aug 23, 2023
Merged

python3.pkgs.pvlib: add missing build dependencies#250823
natsukium merged 1 commit intoNixOS:masterfrom
tjni:pvlib

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

These are needed now that #248866 is committed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.pvlib python311Packages.pvlib

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2023
@tjni tjni mentioned this pull request Aug 22, 2023
Closed
@onny
Copy link
Copy Markdown
Contributor

onny commented Aug 22, 2023

These are a lot of PRs following the python build helper change. Can these be put into one single PR?

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

These are a lot of PRs following the python build helper change. Can these be put into one single PR?

I don't have a strong opinion on this. This is an artifact of my working process: I would finish one issue, post a PR to get the review and CI machinery started, and then move on to the next one. I'm never sure if I will have the energy to finish the next issue I start working on. I can certainly batch them into larger PRs.

@onny
Copy link
Copy Markdown
Contributor

onny commented Aug 22, 2023

Maybe it depends on how much Python PRs regarding this issue will follow. Is it more than 30 PRs maybe bundling them would be better

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

There are currently 64 remaining known breakages that I am making my way through in #247287. I'll be more mindful of the number of PRs and batch some of them together moving forward.

@onny
Copy link
Copy Markdown
Contributor

onny commented Aug 22, 2023

Nice, thank you so much for your work

@ofborg ofborg bot requested a review from jluttine August 22, 2023 20:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 22, 2023
@natsukium natsukium merged commit e821b41 into NixOS:master Aug 23, 2023
@tjni tjni deleted the pvlib branch August 23, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

@jluttine jluttine Awaiting requested review from jluttine

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjni @onny @natsukium