python3.pkgs.pyopencl: add missing build dependencies#250822
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 23, 2023
tjni:pyopencl
Merged
python3.pkgs.pyopencl: add missing build dependencies#250822natsukium merged 1 commit intoNixOS:masterfrom tjni:pyopencl
natsukium merged 1 commit intoNixOS:masterfrom
tjni:pyopencl
Conversation
Contributor
Author
|
@ofborg build python310Packages.pyopencl python311Packages.pyopencl |
Member
|
Sorry, I just merged the version bump, and it caused a conflict. |
Contributor
Author
No problem! It's because I did some minor reformatting that wasn't necessary. Also, a better idea to merge the bot's PR, as I don't know if it knows how to resolve merge conflicts. |
Contributor
Author
|
@ofborg build python310Packages.pyopencl python311Packages.pyopencl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I can't easily test this, because these missing dependencies only fail on staging (and now on staging-next), and I don't have a Linux machine that can build the world. However, based on the Hydra message from a previous python-updates run and perusing the pyproject.toml, these dependencies should be required.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)