wapiti: 3.1.7 -> 3.1.8#250814
Merged
fabaff merged 1 commit intoNixOS:masterfrom Aug 23, 2023
tjni:wapiti
Merged
Conversation
Contributor
Author
|
@ofborg build wapiti |
Member
|
Result of 2 packages failed to build:
I get this with error: builder for '/nix/store/l2f6lnf8122xp8xg362dzi4rgjy1s96i-wapiti-3.1.8.drv' failed with exit code 1;
last 10 log lines:
> =============================== warnings summary ===============================
> ../../nix/store/xm0kn6advd10ygwd6014qp6lv7dv73kn-python3.10-arsenic-21.8/lib/python3.10/site-packages/arsenic/services.py:5
> /nix/store/xm0kn6advd10ygwd6014qp6lv7dv73kn-python3.10-arsenic-21.8/lib/python3.10/site-packages/arsenic/services.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
> from distutils.version import StrictVersion
>
> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
> =========================== short test summary info ============================
> FAILED tests/attack/test_mod_log4shell.py::test_attack_unifi - AttributeError: 'ModuleLog4Shell' object has no attribute '_dns_host'
> ========== 1 failed, 149 passed, 103 deselected, 1 warning in 30.08s =========== |
Contributor
Author
|
Wow, thank you for checking. I think this slipped through because I was testing on aarch64-darwin, and when the hole is punched through the sandbox for localhost, it might also allow arbitrary DNS lookups? Essentially, this line creates the and the new test |
Contributor
Author
|
@ofborg build wapiti |
Member
|
Result of 2 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
wapiti-scanner/wapiti@3.1.7...3.1.8
The goal is to pick up upstream's change to
pyproject.toml, which fixes a bug involving duplicate scripts breakinginstallerwhen it installs the wheel.A couple of other changes are needed to dependencies (which I audited from the new pyproject.toml). One thing to call out is that there is a new extra called
sslwhich I could not add because it depends onsslyze, which depends onnassland tries to download OpenSSL and build it from source. It's more work than I have time for to untangle that right now.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)