Skip to content

python3.pkgs.jarowinkler: fix build dependencies#250706

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:jarowinkler
Aug 23, 2023
Merged

python3.pkgs.jarowinkler: fix build dependencies#250706
natsukium merged 1 commit intoNixOS:masterfrom
tjni:jarowinkler

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

These changes are needed now that #248866 has been committed.

  1. Relax scikit-build dependency in postPatch.
  2. Allow using Cython 0.29 in postPatch because it does not support the final released version 3.0.0 of Cython yet.
  3. Add wheel as an explicit build-time dependency (which will be required soon).
  4. Pass in actual ninja and cmake instead of ninja and cmake Python modules. jarowinkler has a custom build backend that can use them directly

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.jarowinkler python311Packages.jarowinkler

@ofborg ofborg bot requested a review from dotlambda August 22, 2023 08:34
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 22, 2023
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit 7c86daf into NixOS:master Aug 23, 2023
@tjni tjni deleted the jarowinkler branch August 23, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants