Skip to content

python3.pkgs.fiona: relax build dependencies#250700

Merged
tjni merged 1 commit intoNixOS:masterfrom
tjni:fiona
Aug 23, 2023
Merged

python3.pkgs.fiona: relax build dependencies#250700
tjni merged 1 commit intoNixOS:masterfrom
tjni:fiona

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

Since #248866, this package no longer builds because it enforces stronger build-time dependency validation. These issues have been fixed upstream but are combined with other changes and have not yet been released, so I chose to patch the dependency constraints in postPatch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

@ofborg build python310Packages.fiona python311Packages.fiona

@ofborg ofborg bot requested review from imincik, nh2, sikmir and willcohen August 22, 2023 07:55
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 22, 2023
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me.

@tjni tjni merged commit 50eeacc into NixOS:master Aug 23, 2023
@tjni tjni deleted the fiona branch August 23, 2023 21:55
@imincik
Copy link
Copy Markdown
Contributor

imincik commented Aug 24, 2023

Thank you for the fix @tjni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants