Skip to content

matrix-synapse: relax build dependencies#250671

Merged
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:matrix-synapse
Aug 24, 2023
Merged

matrix-synapse: relax build dependencies#250671
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:matrix-synapse

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

After #248866 was committed, matrix-synapse needs to relax its build dependency constraint on poetry-core. Per upstream:

# The upper bounds here are defensive, intended to prevent situations like
# #13849 and #14079 where we see buildtime or runtime errors caused by build
# system changes.
# We are happy to raise these upper bounds upon request,
# provided we check that it's safe to do so (i.e. that CI passes).

These upper bounds are restrictive on purpose, and so I felt it was appropriate inside nixpkgs to patch out the constraint in postPatch using sed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 22, 2023

@ofborg build matrix-synapse

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 22, 2023
@tjni tjni marked this pull request as draft August 24, 2023 00:16
@tjni tjni changed the base branch from master to staging-next August 24, 2023 00:16
@tjni tjni marked this pull request as ready for review August 24, 2023 00:17
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 24, 2023

Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier.

@tjni tjni merged commit efd6699 into NixOS:staging-next Aug 24, 2023
@tjni tjni deleted the matrix-synapse branch August 24, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant