python3.pkgs.jupytext: relax build dependencies#250665
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 22, 2023
tjni:jupytext
Merged
python3.pkgs.jupytext: relax build dependencies#250665natsukium merged 1 commit intoNixOS:masterfrom tjni:jupytext
natsukium merged 1 commit intoNixOS:masterfrom
tjni:jupytext
Conversation
Member
|
@ofborg build python310Packages.jupytext |
GaetanLepage
approved these changes
Aug 22, 2023
Contributor
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM, thanks @tjni !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
After #248866, we have stronger build-time dependency validation, so this package needs its
jupyter-packagingandjupyterlabdependencies relaxed.The constraint in
jupyer-packagingseems to be historical (and I submitted a PR upstream that will hopefully relax it in the future), while the constraint onjupyterlabseems to be only needed for a small subset of the functionality (per comments on mwouts/jupytext#1068). (In any case, recent versions of both packages are already being used in the build; the constraint is just not being checked right now.)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)