Skip to content

python3.pkgs.cmsis-pack-manager: fix install using pypa installer#250649

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:cmsis-pack-manager
Aug 23, 2023
Merged

python3.pkgs.cmsis-pack-manager: fix install using pypa installer#250649
natsukium merged 1 commit intoNixOS:masterfrom
tjni:cmsis-pack-manager

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 22, 2023

Description of changes

After #248866 was committed, we now use installer instead of pip to install wheels. As reported in pyocd/cmsis-pack-manager#207, we cannot install this from the PyPI artifact: for some reason, the wheel that is created has duplicated files in the archive, and installer does not like it.

This isn't a problem when installing from the GitHub sources.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2023
@ofborg ofborg bot requested a review from sbruder August 22, 2023 02:35
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 22, 2023
@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.cmsis-pack-manager

Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit b5f1a01 into NixOS:master Aug 23, 2023
@tjni tjni deleted the cmsis-pack-manager branch August 23, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants