pypaInstallHook: enter "dist" directory before installing#250464
Merged
FRidh merged 1 commit intoNixOS:stagingfrom Aug 21, 2023
tjni:better-install-hook
Merged
pypaInstallHook: enter "dist" directory before installing#250464FRidh merged 1 commit intoNixOS:stagingfrom tjni:better-install-hook
FRidh merged 1 commit intoNixOS:stagingfrom
tjni:better-install-hook
Conversation
Member
|
Same issue as with build. Have you tested this with some builds? |
Member
|
I tested some builds on top of 8410e34306c94b03cbeb6facac4cffb4b4bd3551 (last python-updates run). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
openshot-qt has an
installerdirectory in its source tree, which breaks the current simple logic in pypaInstallHook. Let's fix that by always entering thedistdirectory before we install.I paid a bit more attention to the log output and decided to silence the success output of
pushdandpopd, which just prints the directory stack and isn't useful and added a message to report when a wheel was successfully installed to mirror the output ofpypaBuildHook(except without the nice terminal colors thatbuilduses)./cc @FRidh
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)