Skip to content

python3.pkgs.pyemd: add missing build dependencies#250262

Merged
matthiasbeyer merged 1 commit intoNixOS:masterfrom
tjni:pyemd
Aug 20, 2023
Merged

python3.pkgs.pyemd: add missing build dependencies#250262
matthiasbeyer merged 1 commit intoNixOS:masterfrom
tjni:pyemd

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

These are needed for the build (either in pyproject.toml or setup.py) and will become failures when we switch to build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 19, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 19, 2023

@ofborg build python310Packages.pyemd python311Packages.pyemd

@ofborg ofborg bot requested a review from rvl August 19, 2023 22:58
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 19, 2023
@matthiasbeyer
Copy link
Copy Markdown
Contributor

Result of nixpkgs-review pr 250262 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python311Packages.textacy
  • python311Packages.textacy.dist
6 packages built:
  • python310Packages.pyemd
  • python310Packages.pyemd.dist
  • python310Packages.textacy
  • python310Packages.textacy.dist
  • python311Packages.pyemd
  • python311Packages.pyemd.dist

@matthiasbeyer matthiasbeyer merged commit 5d16328 into NixOS:master Aug 20, 2023
@tjni tjni deleted the pyemd branch August 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants