Skip to content

python3.pkgs.aiomysql: fix build dependency constraints#250206

Merged
tjni merged 1 commit intoNixOS:masterfrom
tjni:aiomysql
Aug 19, 2023
Merged

python3.pkgs.aiomysql: fix build dependency constraints#250206
tjni merged 1 commit intoNixOS:masterfrom
tjni:aiomysql

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

  1. Pull patch that updates setuptools-scm and removes setuptools-scm-git-archive.
  2. Add wheel as an explicit build dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 19, 2023
@tjni tjni mentioned this pull request Aug 19, 2023
Closed
@matthiasbeyer
Copy link
Copy Markdown
Contributor

matthiasbeyer commented Aug 19, 2023

Shouldn't we wait until the PR you linked in the diff lands in a release?

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 19, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 19, 2023

It's unclear when a release will be made, and I need something like that for the work in #247287, because building a package with build validates build dependency constraints. At the moment, the failing constraint is that setuptools-scm in nixpkgs is too recent.

@matthiasbeyer
Copy link
Copy Markdown
Contributor

matthiasbeyer commented Aug 19, 2023

Result of nixpkgs-review pr 250206 run on x86_64-linux 1

8 packages marked as broken and skipped:
  • python310Packages.orm
  • python310Packages.orm.dist
  • python310Packages.ormar
  • python310Packages.ormar.dist
  • python311Packages.orm
  • python311Packages.orm.dist
  • python311Packages.ormar
  • python311Packages.ormar.dist
4 packages built:
  • python310Packages.aiomysql
  • python310Packages.aiomysql.dist
  • python311Packages.aiomysql
  • python311Packages.aiomysql.dist

@tjni tjni merged commit 81e317a into NixOS:master Aug 19, 2023
@tjni tjni deleted the aiomysql branch August 19, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @matthiasbeyer