pipenv: remove wheel install test, enable unit tests#250153
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 22, 2023
tjni:pipenv
Merged
pipenv: remove wheel install test, enable unit tests#250153tjni merged 1 commit intoNixOS:masterfrom tjni:pipenv
tjni merged 1 commit intoNixOS:masterfrom
tjni:pipenv
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The current test for pipenv installs
wheelusing the binary. However, when updatingwheelto version 0.40.0+, it has switched from setuptools to flit-core as the build backend, and pipenv now tries to download flit-core from the Internet. I do not know how to fix this test, so instead I removed it and enabled at least the unit tests for some validation.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)