Skip to content

python3.pkgs.python-rtmidi: 1.5.4 -> 1.5.5#250117

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:python-rtmidi
Aug 21, 2023
Merged

python3.pkgs.python-rtmidi: 1.5.4 -> 1.5.5#250117
natsukium merged 1 commit intoNixOS:masterfrom
tjni:python-rtmidi

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 19, 2023

Description of changes

https://github.com/SpotlightKid/python-rtmidi/releases/tag/1.5.5

I was adding some build dependencies that were needed in this package. The update picks up some fixes for Cython 3 as well after adding that as a build dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 19, 2023
@ofborg ofborg bot requested a review from mweinelt August 19, 2023 06:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 19, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 19, 2023

@ofborg build python310Packages.python-rtmidi python311Packages.python-rtmidi

@natsukium
Copy link
Copy Markdown
Member

It is already broken on darwin.
https://hydra.nixos.org/build/231633375

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 250117 run on x86_64-linux 1

17 packages built:
  • cantoolz
  • cantoolz.dist
  • ledfx
  • ledfx.dist
  • open-stage-control
  • pianotrans
  • pianotrans.dist
  • python310Packages.mido
  • python310Packages.mido.dist
  • python310Packages.piano-transcription-inference
  • python310Packages.piano-transcription-inference.dist
  • python310Packages.python-rtmidi
  • python310Packages.python-rtmidi.dist
  • python311Packages.mido
  • python311Packages.mido.dist
  • python311Packages.python-rtmidi
  • python311Packages.python-rtmidi.dist

@natsukium natsukium merged commit a7d8793 into NixOS:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants