ansible-later: use poetry-dynamic-versioning like upstream#250114
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 22, 2023
tjni:ansible-later
Merged
ansible-later: use poetry-dynamic-versioning like upstream#250114tjni merged 1 commit intoNixOS:masterfrom tjni:ansible-later
tjni merged 1 commit intoNixOS:masterfrom
tjni:ansible-later
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Ongoing work switching to building Python packages with build revealed that upstream uses poetry-dynamic-versioning in its build. This pulls in a patch to fix upstream's usage of this and adds it as a build dependency. This enables removing the postPatch because this is taken care of automatically via an environment variable set in poetry-dynamic-versioning's setup hook.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)