anki: remove pip from anki-build-python#250059
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 19, 2023
tjni:anki
Merged
Conversation
euank
approved these changes
Aug 19, 2023
Member
euank
left a comment
There was a problem hiding this comment.
I verified it still builds and runs on x86 linux just fine for me.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I am trying to fix this failure on the python-updates branch, which is testing some changes that includes updating
pip:I am not sure why it doesn't happen currently. I'm not able to test the behavior of the application, because I'm on macOS, but I have been able to verify it still builds on aarch64-linux. If anyone is able to better test this, please do!
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)