python3.pkgs.python-swiftclient: patch out duplicate script#249854
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 18, 2023
tjni:python-swiftclient
Merged
python3.pkgs.python-swiftclient: patch out duplicate script#249854natsukium merged 1 commit intoNixOS:masterfrom tjni:python-swiftclient
natsukium merged 1 commit intoNixOS:masterfrom
tjni:python-swiftclient
Conversation
Member
|
@ofborg build python310Packages.python-swiftclient |
natsukium
approved these changes
Aug 18, 2023
Member
That's not the problem usually, the contributed patches are not always looked at and can take a good while to get merged and released. |
Comment on lines
+28
to
+29
| sed -i '/^scripts =/d' setup.cfg | ||
| sed -i '/bin\/swift/d' setup.cfg |
Member
There was a problem hiding this comment.
This could be combined into one sed call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
There is a name collision between the scripts that are created from the
scriptssection of setup.cfg and theentry_pointssection of setup.cfg. Whilepipis OK with this,installeris not.It would be better to create a patch upstream and fetch it, but it's a lot of work I don't want to do right now to create an account on Gerrit and set up everything to contribute to an OpenStack project.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)