Skip to content

awsebcli: fixup, remove scripts from setup.py#249850

Merged
delroth merged 1 commit intoNixOS:python-updatesfrom
kirillrdy:python-updates
Aug 18, 2023
Merged

awsebcli: fixup, remove scripts from setup.py#249850
delroth merged 1 commit intoNixOS:python-updatesfrom
kirillrdy:python-updates

Conversation

@kirillrdy
Copy link
Copy Markdown
Member

@kirillrdy kirillrdy commented Aug 18, 2023

Description of changes

fix awsebcli build on python-update branch

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kirillrdy kirillrdy requested a review from tjni August 18, 2023 00:29
Copy link
Copy Markdown
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me. Thank you so much for fixing this!

@ofborg ofborg bot requested a review from eqyiel August 18, 2023 00:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2023
@delroth
Copy link
Copy Markdown
Contributor

delroth commented Aug 18, 2023

Darwin CI failures appear unrelated, merging.

@delroth delroth merged commit 15097f1 into NixOS:python-updates Aug 18, 2023
@kirillrdy kirillrdy deleted the python-updates branch August 18, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants