flatcam: do not pin setuptools in shapely#249849
Merged
tjni merged 1 commit intoNixOS:staging-nextfrom Aug 24, 2023
tjni:flatcam
Merged
flatcam: do not pin setuptools in shapely#249849tjni merged 1 commit intoNixOS:staging-nextfrom tjni:flatcam
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:flatcam
Conversation
Member
|
I suggest that we update the version of shapely as per this comment. #249847 (comment) |
Member
|
I found this while drowning in the sea of PR. |
12 tasks
Contributor
Author
|
Merging this first to unbreak the build. Will follow up on updating it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In the 1.8.x branch of shapely, setuptools was pinned to less than 64 because of a bug the maintainers were seeing related to Windows tests (shapely/shapely#1481). We don't have that problem, and in fact we are on a newer version of setuptools. Once we migrate to
build, this version constraint will start failing the build.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)