etesync-dav: pull patch into flask to work with setuptools 67.5.0+#249847
Merged
tjni merged 1 commit intoNixOS:staging-nextfrom Aug 24, 2023
tjni:etesync-dav
Merged
etesync-dav: pull patch into flask to work with setuptools 67.5.0+#249847tjni merged 1 commit intoNixOS:staging-nextfrom tjni:etesync-dav
tjni merged 1 commit intoNixOS:staging-nextfrom
tjni:etesync-dav
Conversation
Member
|
IMO it would be better to version up instead of the patch since upstream does not pin the flask version. I would like to hear from the package maintainers, @thyol and @Valodim. |
12 tasks
Contributor
Author
|
I do think unpinning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Pull a patch into version 2.0.3 of flask that replaces usages of pkg_resources. In setuptools 67.5.0+, this starts to output a deprecation warning, which fails flask's tests. While we could stop running tests or patch how it responds to warnings, I thought we could use the patch to improve the behavior without changing the testing.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)