Skip to content

cve-bin-tool: add wheel dependency to pinned packaging#249842

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:cve-bin-tool
Aug 18, 2023
Merged

cve-bin-tool: add wheel dependency to pinned packaging#249842
natsukium merged 1 commit intoNixOS:masterfrom
tjni:cve-bin-tool

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 17, 2023

Description of changes

We will soon switch to building Python packages using build, which validates that all of the build dependencies requested in pyproject.toml are present, so wheel needs to be added to the build dependencies of the pinned packaging version inside of cve-bin-tool.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 17, 2023
@natsukium natsukium merged commit 8bc8db9 into NixOS:master Aug 18, 2023
@tjni tjni deleted the cve-bin-tool branch August 18, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants