cobang: minor fix to patch replacing poetry with poetry-core#249841
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 18, 2023
tjni:cobang
Merged
cobang: minor fix to patch replacing poetry with poetry-core#249841natsukium merged 1 commit intoNixOS:masterfrom tjni:cobang
natsukium merged 1 commit intoNixOS:masterfrom
tjni:cobang
Conversation
natsukium
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As I was working on migrating Python builds to use
build, it flagged that the patch being used to replace poetry with poetry-core was missing one replacement. I've fixed that here.Note that
cobangis still broken on master after the pillow update. How it should be fixed is updated to v0.10.1, after which the current poetry patch can be removed, and then also patched to work with pillow v10. However, I would like to merge this small fix in the meantime because it changes the error signature to what is really wrong, which is that support for the new major version of pillow needs to be added.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)