aws-mfa: fix script duplication when installing with installer#249821
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 18, 2023
tjni:aws-mfa
Merged
aws-mfa: fix script duplication when installing with installer#249821natsukium merged 1 commit intoNixOS:masterfrom tjni:aws-mfa
natsukium merged 1 commit intoNixOS:masterfrom
tjni:aws-mfa
Conversation
Member
|
|
natsukium
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I'm working on changing how we install Python packages from using
pipto usinginstaller. Unlike pip, it throws an error when it finds two files with the same name in a wheel archive, and that is the case because aws-mfa defines both a script and a console script entry point with the same name.This PR pulls in a patch I submitted upstream to fix this.
I also made a few opportunistic changes (e.g. using SRI hash, adding
formatattribute, removing unnecessary list around the license).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)