awscli2: enable building without pip in the environment#249798
Merged
natsukium merged 1 commit intoNixOS:masterfrom Aug 18, 2023
tjni:awscli2
Merged
awscli2: enable building without pip in the environment#249798natsukium merged 1 commit intoNixOS:masterfrom tjni:awscli2
natsukium merged 1 commit intoNixOS:masterfrom
tjni:awscli2
Conversation
Member
|
|
natsukium
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This package has a special check that runs prior to building that checks for
pipin the environment. We do not needpipin the environment (it's only there right now by coincidence and will be removed soon) as we provide all the dependencies needed through PYTHONPATH. So we need to relax this check from upstream.I did this in
postPatchbecause it's not clear to me that this is something that should be upstreamed. (It looks like it has been added specifically to address some concern in their environment.)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)