Skip to content

python3.pkgs.levenshtein: update to cython 3#249779

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:levenshtein
Aug 18, 2023
Merged

python3.pkgs.levenshtein: update to cython 3#249779
natsukium merged 1 commit intoNixOS:masterfrom
tjni:levenshtein

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 17, 2023

Description of changes

Upstream actually asks for it in its pyproject.toml, which was discovered when testing building with stronger dependency validation using build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 17, 2023
@ofborg ofborg bot requested a review from fabaff August 17, 2023 18:10
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 17, 2023
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 17, 2023

@ofborg build python310Packages.levenshtein python311Packages.levenshtein

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 249779 run on x86_64-linux 1

5 packages failed to build:
  • apostrophe
  • python310Packages.autofaiss
  • python310Packages.autofaiss.dist
  • python311Packages.autofaiss
  • python311Packages.autofaiss.dist
56 packages built:
  • adl
  • anime-downloader
  • anime-downloader.dist
  • atomic-operator
  • atomic-operator.dist
  • creds
  • creds.dist
  • ibus-engines.uniemoji
  • ledger-autosync
  • ledger-autosync.dist
  • paperwork
  • paperwork.dist
  • puddletag
  • puddletag.dist
  • pynitrokey
  • pynitrokey.dist
  • python310Packages.fire
  • python310Packages.fire.dist
  • python310Packages.fuzzywuzzy
  • python310Packages.fuzzywuzzy.dist
  • python310Packages.levenshtein
  • python310Packages.levenshtein.dist
  • python310Packages.nkdfu
  • python310Packages.nkdfu.dist
  • python310Packages.paperwork-backend
  • python310Packages.paperwork-backend.dist
  • python310Packages.paperwork-shell
  • python310Packages.paperwork-shell.dist
  • python310Packages.thefuzz
  • python310Packages.thefuzz.dist
  • trytond (python310Packages.trytond)
  • trytond.dist (python310Packages.trytond.dist)
  • python310Packages.videocr
  • python310Packages.videocr.dist
  • python311Packages.fire
  • python311Packages.fire.dist
  • python311Packages.fuzzywuzzy
  • python311Packages.fuzzywuzzy.dist
  • python311Packages.levenshtein
  • python311Packages.levenshtein.dist
  • python311Packages.nkdfu
  • python311Packages.nkdfu.dist
  • python311Packages.paperwork-backend
  • python311Packages.paperwork-backend.dist
  • python311Packages.paperwork-shell
  • python311Packages.paperwork-shell.dist
  • python311Packages.thefuzz
  • python311Packages.thefuzz.dist
  • python311Packages.trytond
  • python311Packages.trytond.dist
  • python311Packages.videocr
  • python311Packages.videocr.dist
  • sublime-music
  • sublime-music.dist
  • ulauncher
  • ulauncher.dist

Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem to break other packages.

@natsukium natsukium merged commit e3fdb92 into NixOS:master Aug 18, 2023
@tjni tjni deleted the levenshtein branch August 18, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants