Skip to content

mumble: 1.4.287 -> 1.5.517#249762

Closed
K900 wants to merge 2 commits intoNixOS:masterfrom
K900:mumble-1.5
Closed

mumble: 1.4.287 -> 1.5.517#249762
K900 wants to merge 2 commits intoNixOS:masterfrom
K900:mumble-1.5

Conversation

@K900
Copy link
Copy Markdown
Contributor

@K900 K900 commented Aug 17, 2023 •
edited
Loading

This is technically an RC release, but it contains all the fixes we've been vendoring and then some. Also, 1.4 doesn't build on staging-next anymore. This removes gRPC support, because upstream also removed it.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@K900
mumble: 1.4.287 -> 1.5.517
9ca9698 
This is technically an RC release, but it contains all the fixes we've been vendoring and then some.
Also, 1.4 doesn't build on staging-next anymore. This removes gRPC support, because upstream also removed it.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Aug 17, 2023
@ofborg ofborg bot requested review from felixsinger and infinisil August 17, 2023 16:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 17, 2023
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 17, 2023
@cafkafk
Copy link
Copy Markdown
Member

cafkafk commented Aug 17, 2023 •
edited
Loading

Result of nixpkgs-review pr 249762 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
4 packages built:
  • ioquake3
  • mumble
  • murmur
  • quake3demo

Tested basic functionality, joining servers, discovering servers etc.

felixsinger
felixsinger suggested changes Aug 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@felixsinger felixsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release candidate is not a release. It's a... candidate. 1.5.517 has many issues and shouldn't be used.

Why does the current version not build on staging-next anymore?

@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Aug 18, 2023

There seem to be multiple issues with latest Protobuf and gRPC versions at the very least. I guess we can try disabling gRPC and keeping the old version...

@K900 K900 mentioned this pull request Aug 18, 2023
Merged
12 tasks
@K900
Copy link
Copy Markdown
Contributor Author

K900 commented Aug 18, 2023

So yeah, disabling gRPC and downgrading Protobuf works. I guess we can try doing that, unless someone is willing to patch the current version of Mumble to build with the new gRPC...

@felixsinger
Copy link
Copy Markdown
Member

felixsinger commented Aug 18, 2023

There seem to be multiple issues with latest Protobuf and gRPC versions at the very least. I guess we can try disabling gRPC and keeping the old version...

Since Mumble does not support gRPC anymore, let's just disable it.

@K900 K900 closed this Aug 18, 2023
@K900 K900 deleted the mumble-1.5 branch July 27, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil Awaiting requested review from infinisil

1 more reviewer

@felixsinger felixsinger felixsinger requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@K900 @cafkafk @felixsinger