Skip to content

python3.pkgs.dask: remove references to versioneer#249486

Merged
natsukium merged 1 commit intoNixOS:masterfrom
tjni:dask
Aug 19, 2023
Merged

python3.pkgs.dask: remove references to versioneer#249486
natsukium merged 1 commit intoNixOS:masterfrom
tjni:dask

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 16, 2023

Description of changes

The current version of versioneer in nixpkgs is 0.29, while dask pins its versioneer dependency to 0.29 0.28. I submitted a PR upstream to unpin it, but upon closer inspection it looks like we patch out versioneer in the code. This change removes references to it from a few other places and tries to remove the dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 16, 2023
@ofborg ofborg bot requested a review from FRidh August 16, 2023 08:25
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 16, 2023
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Aug 16, 2023

The current version of versioneer in nixpkgs is 0.29, while dask pins its versioneer dependency to 0.29.

one of these is 0.28

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 16, 2023

Oops, good catch. Fixed.

@natsukium
Copy link
Copy Markdown
Member

@ofborg build python310Packages.dask

@natsukium natsukium merged commit 5a88a87 into NixOS:master Aug 19, 2023
@tjni tjni deleted the dask branch August 19, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants