Skip to content

python3.pkgs.matplotlib: add missing build dependencies#249459

Merged
veprbl merged 1 commit intoNixOS:stagingfrom
tjni:matplotlib
Aug 20, 2023
Merged

python3.pkgs.matplotlib: add missing build dependencies#249459
veprbl merged 1 commit intoNixOS:stagingfrom
tjni:matplotlib

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 16, 2023

Description of changes

These dependencies will be needed once we switch to building Python packages with build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 16, 2023
@tjni tjni mentioned this pull request Aug 16, 2023
Closed
@ofborg ofborg bot requested review from lovek323 and veprbl August 16, 2023 04:57
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 16, 2023
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Aug 16, 2023

@ofborg build python310Packages.matplotlib python311Packages.matplotlib

natsukium
natsukium approved these changes Aug 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherry picked this commit to the local master and did not find the error as reported in the CI.

veprbl
veprbl reviewed Aug 19, 2023
View reviewed changes
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Aug 19, 2023

@ofborg build python310Packages.matplotlib python311Packages.matplotlib

@ofborg ofborg bot requested a review from veprbl August 19, 2023 22:12
@veprbl veprbl merged commit 2aa7c01 into NixOS:staging Aug 20, 2023
@tjni tjni deleted the matplotlib branch August 20, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@veprbl veprbl Awaiting requested review from veprbl

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjni @fabaff @veprbl @natsukium