Skip to content

libgcc: build arm-{isa,cpu}.h for all 32-bit arm, not just armv7#249439

Merged
2 commits merged intomasterfrom
unknown repository
Aug 17, 2023
Merged

libgcc: build arm-{isa,cpu}.h for all 32-bit arm, not just armv7#249439
2 commits merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 16, 2023

As reported here:

Will undraftify when tested.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from lopsided98 August 16, 2023 02:12
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 16, 2023
@ghost ghost marked this pull request as ready for review August 16, 2023 05:04
Copy link
Copy Markdown
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes my armv6l and armv5tel machines, thanks!

@ghost ghost merged commit 53a053c into NixOS:master Aug 17, 2023
@ghost ghost deleted the pr/stdenv/libgcc-no-more-cycles-armv5-and-armv6 branch August 17, 2023 04:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant