stdenv: cross: updateAutotoolsGnuConfigScriptsHook unconditionally#249071
Conversation
We updateAutotoolsGnuConfigScriptsHook unconditionally in the native bootstrap; there's no reason to conditionalize it here.
|
Are you saying it already is an unconditional extra dep in the native bootstrap? Then I don't we need this bit at all! |
Not quite. See 3b8e3c1. It is a dependency of native The point of my comment above was that this PR will not increase the number of rebuilds caused by future |
|
3b8e3c1#diff-bf918d7f48f6a34a4a1acb33373dee717cff2c3f5503a7ca41d90e5f289faf1eR615 doesn't that line make it part of the final stdenv / used by anything which is built with that stdenv? |
Co-authored-by: John Ericson <git@JohnEricson.me>
You're right. I forgot that I guess they are really propagated native build inputs, propagated from |
|
My only remaining concern is that In spite of the fact that it's a shell script, Nix believes that But I'm having a hard time making this happen. I need to read |
|
Ah, I see. You can never change the That explains it. |
Description of changes
We updateAutotoolsGnuConfigScriptsHook unconditionally in the native bootstrap; there's no reason to conditionalize it here.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)