python3.pkgs.insteon-frontend-home-assistant: unpin setuptools dependency#248859
python3.pkgs.insteon-frontend-home-assistant: unpin setuptools dependency#248859natsukium merged 1 commit intoNixOS:masterfrom tjni:insteon-frontend-home-assistant
Conversation
|
Result of 5 packages built:
|
|
@ofborg build python310Packages.insteon-frontend-home-assistant |
|
|
||
| nativeBuildInputs = [ | ||
| setuptools | ||
| wheel |
There was a problem hiding this comment.
Why add wheel given that the patch removes it?
There was a problem hiding this comment.
Good question. The patch removes declaring it as a build dependency in pyproject.toml but it doesn't mean that wheel isn't a dependency. PEP 517 describes that a build backend like setuptools can declare additional build dependencies via the get_requires_for_build_wheel and get_requires_for_build_sdist methods, which setuptools does. It's best practice not to include wheel as a dependency in pyproject.toml because then it will be downloaded even in an sdist build (though that doesn't apply to us in nixpkgs).
Description of changes
This will now pass
buildtool's stronger dependency validation in preparation for switching to it.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)