Skip to content

python3.pkgs.certbot-dns-*: ignore warning in setuptools 67.5.0+#248840

Merged
natsukium merged 4 commits intoNixOS:masterfrom
tjni:certbot-dns-cloudflare
Aug 16, 2023
Merged

python3.pkgs.certbot-dns-*: ignore warning in setuptools 67.5.0+#248840
natsukium merged 4 commits intoNixOS:masterfrom
tjni:certbot-dns-cloudflare

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

Prior to updating to the latest version of setuptools, need to ignore a new DeprecationWarning, pending a solution upstream in certbot/certbot#9606.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 13, 2023
@tjni tjni mentioned this pull request Aug 13, 2023
Closed
@ofborg ofborg bot requested a review from domenkozar August 13, 2023 06:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 13, 2023
@tjni tjni changed the title python3.pkgs.certbot-dns-cloudflare: ignore warning in setuptools 67.5.0+ python3.pkgs.certbot-dns-*: ignore warning in setuptools 67.5.0+ Aug 13, 2023
natsukium
natsukium reviewed Aug 16, 2023
View reviewed changes
natsukium
natsukium approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit 9dc1cef into NixOS:master Aug 16, 2023
@tjni tjni deleted the certbot-dns-cloudflare branch August 16, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @natsukium