Skip to content

python3.pkgs.ninja: export BIN_DIR constant#248826

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
tjni:ninja
Aug 14, 2023
Merged

python3.pkgs.ninja: export BIN_DIR constant#248826
vcunat merged 1 commit intoNixOS:staging-nextfrom
tjni:ninja

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

This is used by ale-py here.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 13, 2023
@tjni tjni mentioned this pull request Aug 13, 2023
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 13, 2023
@tjni tjni marked this pull request as draft August 14, 2023 16:56
@tjni tjni changed the base branch from staging to staging-next August 14, 2023 17:01
@tjni tjni marked this pull request as ready for review August 14, 2023 17:01
@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 14, 2023 •
edited
Loading

I did not catch this early enough, and #246963 broke staging-next in #248496. I verify locally that this change fixes the issue there with rapidfuzz. If CI passes, I'm going to merge this to fix that issue.

@vcunat vcunat mentioned this pull request Aug 14, 2023
Merged
2 tasks
@vcunat vcunat merged commit f11e74c into NixOS:staging-next Aug 14, 2023
@tjni tjni deleted the ninja branch August 14, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjni @dotlambda @vcunat