play-with-mpv: unstable-2020-05-18 -> unstable-2021-04-02#248822
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 17, 2023
tjni:play-with-mpv
Merged
play-with-mpv: unstable-2020-05-18 -> unstable-2021-04-02#248822tjni merged 1 commit intoNixOS:masterfrom tjni:play-with-mpv
tjni merged 1 commit intoNixOS:masterfrom
tjni:play-with-mpv
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I took the opportunity to update this package a few more commits:
https://github.com/Thann/play-with-mpv/commits/master
But the main motivation is that some changes I am making to Python bootstrapping are revealing missing dependencies that were being silently ignored before. (I think pip was being used to attempt to download them, and then the build continued afterward when that download fails.)
Here, the main change is that the custom build of install-freedesktop needs to be an actual Python package in order for setuptools to recognize that it's a fulfilled dependency.
We can also get rid of the
gitdependency if we replace the version in setup.py with a valid version string.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)