Skip to content

play-with-mpv: unstable-2020-05-18 -> unstable-2021-04-02#248822

Merged
tjni merged 1 commit intoNixOS:masterfrom
tjni:play-with-mpv
Aug 17, 2023
Merged

play-with-mpv: unstable-2020-05-18 -> unstable-2021-04-02#248822
tjni merged 1 commit intoNixOS:masterfrom
tjni:play-with-mpv

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 13, 2023

Description of changes

I took the opportunity to update this package a few more commits:

https://github.com/Thann/play-with-mpv/commits/master

But the main motivation is that some changes I am making to Python bootstrapping are revealing missing dependencies that were being silently ignored before. (I think pip was being used to attempt to download them, and then the build continued afterward when that download fails.)

Here, the main change is that the custom build of install-freedesktop needs to be an actual Python package in order for setuptools to recognize that it's a fulfilled dependency.

We can also get rid of the git dependency if we replace the version in setup.py with a valid version string.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dawidsowa August 13, 2023 03:35
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 13, 2023
@tjni tjni merged commit 6f5c153 into NixOS:master Aug 17, 2023
@tjni tjni deleted the play-with-mpv branch August 17, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant