openrazer-daemon: do not install twice#248800
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 17, 2023
tjni:openrazer-daemon
Merged
openrazer-daemon: do not install twice#248800tjni merged 1 commit intoNixOS:masterfrom tjni:openrazer-daemon
tjni merged 1 commit intoNixOS:masterfrom
tjni:openrazer-daemon
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
While working on switching the Python package installer from pip to installer, discovered that this package was installing the same files twice. Its postBuild phase runs "make install", which calls "setup.py install". Then, in installPhase, pip is used to install again. This begins to break with installer, which notices that files it is writing to already exist. This PR fixes that by only calling the Makefile targets that do not install the Python wheel. In addition:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)