Skip to content

python311Packages.mcstatus: 11.0.0 -> 11.0.1#248787

Merged
fabaff merged 1 commit intoNixOS:masterfrom
tjni:mcstatus
Aug 13, 2023
Merged

python311Packages.mcstatus: 11.0.0 -> 11.0.1#248787
fabaff merged 1 commit intoNixOS:masterfrom
tjni:mcstatus

Conversation

@tjni
Copy link
Copy Markdown
Contributor

@tjni tjni commented Aug 12, 2023 •
edited
Loading

Description of changes

https://github.com/py-mine/mcstatus/releases/tag/v11.0.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 12, 2023
Closed
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 12, 2023
@ofborg ofborg bot requested a review from fabaff August 12, 2023 22:15
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 12, 2023
@tjni tjni changed the title mcstatus: add missing build dependency mcstatus: 11.0.0 -> 11.0.1 Aug 12, 2023
fabaff
fabaff reviewed Aug 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update to commit message?

python311Packages.mcstatus: 11.0.0 -> 11.0.1

@tjni
Copy link
Copy Markdown
Contributor Author

tjni commented Aug 13, 2023

Done!

@ofborg ofborg bot requested a review from fabaff August 13, 2023 10:04
@fabaff fabaff changed the title mcstatus: 11.0.0 -> 11.0.1 python311Packages.mcstatus: 11.0.0 -> 11.0.1 Aug 13, 2023
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Aug 13, 2023

Result of nixpkgs-review pr 248787 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.minecraft_server
  • mcstatus (python310Packages.mcstatus)
  • mcstatus.dist (python310Packages.mcstatus.dist)
  • python311Packages.mcstatus
  • python311Packages.mcstatus.dist

fabaff
fabaff approved these changes Aug 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit a2cb37b into NixOS:master Aug 13, 2023
@tjni tjni deleted the mcstatus branch August 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjni @fabaff